On 1/2/19 9:50 AM, Chee, Tien Fong wrote: > On Tue, 2019-01-01 at 21:35 +0100, Marek Vasut wrote: >> On 1/1/19 4:51 AM, Chee, Tien Fong wrote: >>> >>> On Sun, 2018-12-30 at 16:54 +0100, Marek Vasut wrote: >>>> >>>> On 12/30/18 9:13 AM, tien.fong.c...@intel.com wrote: >>>>> >>>>> >>>>> From: Marek Vasut <ma...@denx.de> >>>>> >>>>> Update the default configuration file to enable the necessary >>>>> functionality >>>>> the get the kit working. That includes SPL SD/MMC support, USB, >>>>> and >>>>> I2C. >>>>> >>>>> Signed-off-by: Marek Vasut <ma...@denx.de> >>>>> Signed-off-by: Tien Fong Chee <tien.fong.c...@intel.com> >>>> Is this patch needed ? Why ? This enables a whole lot of stuff >>>> .... >>> These settings are mostly syn up from gen5 and our own downstream >>> A10. >>> These settings are mostly required to boot U-Boot and supporting >>> A10 >>> golden system reference design. >> Hmmm, mind you, all the MTD and SPI stuff is not needed for the SDMMC >> configuration of the kit, which this patch would imply is the target. >> You want to split this into smaller config changes which enable >> logical >> blocks, not everything at once, and document why is each thing >> needed. > I can keep them minimal, enable them when required in separate patch.
Please do >> >>> >>>> >>>>> >>>>> >>>>> --- >>>>> configs/socfpga_arria10_defconfig | 38 >>>>> +++++++++++++++++++++++++++++++----- >>>>> 1 files changed, 32 insertions(+), 6 deletions(-) >>>>> >>>>> diff --git a/configs/socfpga_arria10_defconfig >>>>> b/configs/socfpga_arria10_defconfig >>>>> index 8158dbb..4b93321 100644 >>>>> --- a/configs/socfpga_arria10_defconfig >>>>> +++ b/configs/socfpga_arria10_defconfig >>>>> @@ -1,7 +1,7 @@ >>>>> CONFIG_ARM=y >>>>> CONFIG_ARCH_SOCFPGA=y >>>>> CONFIG_SYS_TEXT_BASE=0x01000040 >>>>> -CONFIG_SYS_MALLOC_F_LEN=0x2000 >>>>> +CONFIG_SYS_MALLOC_F_LEN=0x8000 >> Why is this increase in malloc area needed ? > This is set in the arria10_sdmmc_next, i guess you need this value for > your use case? I can revert it if it is no longer required. I mean, you're sending a patch, I'd expect you know what it does ? :-) [...] -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
