On 1/2/19 12:37 AM, Lukasz Majewski wrote: > The DM_FLAG_PRE_RELOC shall be enabled as this driver is going to be > re-used in the i.MX based SoCs. > > It is crucial to have running the serial console before relocation.
But the patch doesn't do what the subject/commit message claims is does. If I understand it correctly, it sets the PRE_RELOC flag unconditionally. > Signed-off-by: Lukasz Majewski <lu...@denx.de> > --- > > drivers/serial/serial_mxc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c > index 7e4e6d36b8..e586c18cf0 100644 > --- a/drivers/serial/serial_mxc.c > +++ b/drivers/serial/serial_mxc.c > @@ -354,9 +354,7 @@ U_BOOT_DRIVER(serial_mxc) = { > #endif > .probe = mxc_serial_probe, > .ops = &mxc_serial_ops, > -#if !CONFIG_IS_ENABLED(OF_CONTROL) > .flags = DM_FLAG_PRE_RELOC, > -#endif > }; > #endif > > -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot