On 12/28/18 2:32 PM, Ooi, Joyce wrote: >> -----Original Message----- >> From: Marek Vasut [mailto:ma...@denx.de] >> Sent: Friday, December 28, 2018 6:05 PM >> To: Ooi, Joyce <joyce....@intel.com>; Michal Simek >> <michal.si...@xilinx.com>; Siva Durga Prasad Paladugu >> <siva.durga.palad...@xilinx.com> >> Cc: u-boot@lists.denx.de; See, Chin Liang <chin.liang....@intel.com>; Chee, >> Tien Fong <tien.fong.c...@intel.com>; Tan, Ley Foon >> <ley.foon....@intel.com> >> Subject: Re: [PATCH] rsa: read out public_exponent value based on 32-bit >> alignment >> >> On 12/28/18 8:30 AM, Ooi, Joyce wrote: >>> Hi Marek, >> >> Hi, >> >>> Any comments about this? >> >> Use get_unaligned() ? > It seems that if USE_HOSTCC is enabled, get_unaligned_* can't be used.
Can this be fixed ? > In lib/rsa/rsa-mod-exp.c, > #ifndef USE_HOSTCC > .. > #include <asm/unaligned.h> > #else > #include "fdt_host.h" > #include "mkimage.h" > #include <fdt_support.h> > #endif > > So, to make it more generic (with or without USE_HOSTCC enabled), I read out > the public_exponent as two 32-bit datas and then concatenating them into a > 64-bit data. See above -- I'd much rather see the get_unaligned() fixed and used. -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
