Hi Simon,
> -----Original Message-----
> From: Simon Goldschmidt <simon.k.r.goldschm...@gmail.com>
> Sent: lundi 19 novembre 2018 20:09
>
> On 19.11.2018 18:33, Patrick Delaunay wrote:
> > In case of DT boot, don't read default speed and mode for SPI from
> > CONFIG_*, instead read from DT node.
> >
> > Signed-off-by: Christophe Kerello <christophe.kere...@st.com>
> > Signed-off-by: Patrick Delaunay <patrick.delau...@st.com>
>
> I was commenting about code duplication, which is better now, so:
>
> Reviewed-by: Simon Goldschmidt <simon.k.r.goldschm...@gmail.com>
>
> I do think it would be nice to invert the logic. That way, we could get
> completely
> rid of those two CONFIG_SF_DEFAULT settings for DM_SPI_FLASH boards (and
> eventually for all boards - when's the deadline for that?).
> But there are other places that still do it like you do here, so it's
> probably better
> to change them all at once...
Agree with you.
In fact I hesitate with directly change the header file
#ifdef CONFIG_DM_SPI_FLASH
/* In DM mode defaults will be taken from DT */
#define CONFIG_SF_DEFAULT_SPEED 0
#define CONFIG_SF_DEFAULT_MODE 0
#endif
But I am afraid of the potential impacts (define is used in many boards),
but I think it sould be more cleaner way to force the expected behavior.
Patrick
> Simon
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
