On 11/15/2018 10:23 PM, Marek Vasut wrote: > Reorder the tmio_sd_set_clk_rate() function such that it handles all > of the clock requiests correctly. Specifically, before this patch, > clock request with (mmc->clock == 0 && mmc->clk_disable) could leave > the clock enabled, as the function would exit on if (!mmc->clock) > condition on top and will not handle the mmc->clk_disable at all. > > Rather than band-aid fixing just that particular problem, reorder > the entire function to make it easier to understand and verify that > all the cases are covered. The function has three sections now: > > First, if mmc->clock != 0, we calculate divider for the SD block. > Second, if mmc->clock != 0 and SD block clock are enabled and > current divider is not equal to the new divider, then > stop the clock and update the divider. > Third, if mmc->clk_disable is set, disable the clock, otherwise > enable the clock. This happens independently of divider > update now. > > Signed-off-by: Marek Vasut <marek.vasut+rene...@gmail.com> > Cc: Masahiro Yamada <yamada.masah...@socionext.com>
Yamada-san , can you check this one please ? -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
