> -----Original Message----- > From: Albert ARIBAUD [mailto:albert.arib...@free.fr] > Sent: Friday, April 09, 2010 10:55 AM > To: Prafulla Wadaskar > Cc: U-Boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH V5 1/3] Initial support for > Marvell Orion5x SoC > > Prafulla Wadaskar a écrit : > > Dear Albert > > >> +++ b/cpu/arm926ejs/orion5x/Makefile > >> @@ -0,0 +1,55 @@ > >> +# > >> +# Copyright (C) 2009 Albert ARIBAUD <albert.arib...@free.fr> > > > > General comment for all files, > > You should change copyright statement for year 2010 instead of 2009 > > Drat--didn't realize this. :o) > > > +#define PCIE_DEV_ID_OFF (ORION5X_REG_PCIE_BASE + 0x0000) > > +#define PCIE_DEV_REV_OFF (ORION5X_REG_PCIE_BASE + 0x0008) > > > > These are already defined cpu.h, pls remove it > > Fixed > > >> +++ b/cpu/arm926ejs/orion5x/lowlevel_init.S > >> @@ -0,0 +1,294 @@ > >> +/************************************************************ > >> ******************* > >> +Copyright (c) Albert ARIBAUD <albert.arib...@free.fr> > >> +Redistributed under GPLv2, pursuant to the licensing terms > >> +of the original Marvell U-boot code which is: > >> +Copyright (C) Marvell International Ltd. and its affiliates > >> +************************************************************* > >> ******************* > >> +Marvell GPL License Option > > > > You should put standard GPL statement here as you put for > other files, > > Ok. > > > Also pls remove Marvell GPL statement > > I'd kept the notice as this file is a split from, and major > part of, the > original single lowlevel_init.S which is indeed (c) Marvell;
Well you can mention simple copy write for this # (C) Copyright 2009 # Marvell Semiconductor <www.marvell.com> If you know previous author of that code, you may give credit to them > if you feel > I can remove the reference to Marvell, that's fine with me. > But then, I > should remove it also from > board/LaCie/edminiv2/board_lowlevel_init.S, > should I not? Yes, you should. Let's make/post clean GPL code here. Regards.. Prafulla . . _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
