HI Andy, On 15 November 2018 at 11:37, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Thu, Nov 15, 2018 at 8:30 PM Alexander Graf <ag...@suse.de> wrote: >> On 15.11.18 18:58, Andy Shevchenko wrote: >> > New callback will supply necessary information, for example, >> > to ACPI SPCR table. > >> > +static int ns16550_serial_getinfo(struct udevice *dev, struct >> > serial_device_info *info) >> >> This line is above 80 characters. Please run checkpatch.pl on your patches. > > When you saw last time the terminal for 80 character limit? > I really don't give a crap about 80 characters limit when it uglifies the > code. > > Okay, here is 87 characters, so, I tend to split line as you suggested.
If you use patman it will check this for you. I'm going to hold off on reviewing this since I'm not sure about the struct purpose. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
