On 05.11.18 08:42, akash wrote: > Hi Jagan, > > On 05/11/18 12:40 PM, Jagan Teki wrote: >> On 03/11/18 4:58 PM, Akash Gajjar wrote: >>> Rockpro64 is rk3399 based board from pine64.org. add initial board >>> support for >>> Rockpro64. complete board support will be added later in upcoming >>> patchsets. >>> >>> Signed-off-by: Akash Gajjar <ak...@openedev.com> >>> --- >>> arch/arm/dts/Makefile | 1 + >>> arch/arm/dts/rk3399-rockpro64.dts | 519 +++++++ >> >> Does it pure Linux sync file? if yes mention the commit id details on >> commit message. > Nope, it is not pure Linux sync file. though dts support is queued for > Linux 4.20.
Please make sure to reuse the Linux dts. That way we can in the distro boot path just not load yet another DT and simply reuse the U-Boot one. For stable SoCs (and rk3399 should be one of them) this has worked quite well in the past. >> >>> arch/arm/dts/rk3399-sdram-lpddr4-1600.dtsi | 1535 ++++++++++++++++++++ >> >> Send this separately, more convenient to review ddr changes separately. > Will do this in v2 changes. >> >>> arch/arm/mach-rockchip/rk3399/Kconfig | 10 + >>> board/rockchip/rockpro64/Kconfig | 15 + >>> board/rockchip/rockpro64/MAINTAINERS | 6 + >>> board/rockchip/rockpro64/Makefile | 7 + >>> board/rockchip/rockpro64/rockpro64.c | 94 ++ >>> configs/rockpro64-rk3399_defconfig | 78 + >>> include/configs/rockpro64.h | 15 + >>> 10 files changed, 2280 insertions(+) >>> create mode 100644 arch/arm/dts/rk3399-rockpro64.dts >>> create mode 100644 arch/arm/dts/rk3399-sdram-lpddr4-1600.dtsi >>> create mode 100644 board/rockchip/rockpro64/Kconfig >>> create mode 100644 board/rockchip/rockpro64/MAINTAINERS >>> create mode 100644 board/rockchip/rockpro64/Makefile >>> create mode 100644 board/rockchip/rockpro64/rockpro64.c >>> create mode 100644 configs/rockpro64-rk3399_defconfig >>> create mode 100644 include/configs/rockpro64.h >>> >>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile >>> index d36447d18d..8a84cf55a3 100644 >>> --- a/arch/arm/dts/Makefile >>> +++ b/arch/arm/dts/Makefile >>> @@ -51,6 +51,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \ >>> rk3399-puma-ddr1333.dtb \ >>> rk3399-puma-ddr1600.dtb \ >>> rk3399-puma-ddr1866.dtb \ >>> + rk3399-rockpro64.dtb \ >>> rv1108-evb.dtb >>> dtb-$(CONFIG_ARCH_MESON) += \ >>> meson-gxbb-nanopi-k2.dtb \ >>> diff --git a/arch/arm/dts/rk3399-rockpro64.dts >>> b/arch/arm/dts/rk3399-rockpro64.dts >>> new file mode 100644 >>> index 0000000000..8497a1124b >>> --- /dev/null >>> +++ b/arch/arm/dts/rk3399-rockpro64.dts >>> @@ -0,0 +1,519 @@ >>> +// SPDX-License-Identifier: GPL-2.0+ >>> +/* >>> + * Copyright (c) 2018 Akash Gajjar <ak...@openedev.com> >>> + */ >>> + >>> +/dts-v1/; >>> +#include <dt-bindings/pwm/pwm.h> >>> +#include <dt-bindings/pinctrl/rockchip.h> >>> +#include "rk3399.dtsi" >>> +#include "rk3399-sdram-lpddr4-1600.dtsi" >> >> if this change related to u-boot, just sync Linux dts file and create >> -u-boot.dtsi and include this on that. >> >> Just to understand, what has been tested with this support? > This initial phase patchsets are just to notify community that board > support is in progress. > > In V2 changes will add complete support of u-boot for Rockpro64. When can we expect v2? The merge window is opening :) Alex _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
