Hi Bin, On 12 October 2018 at 20:46, Bin Meng <bmeng...@gmail.com> wrote: > Hi Heinrich, > > On Fri, Oct 12, 2018 at 3:56 AM Heinrich Schuchardt <xypron.g...@gmx.de> > wrote: >> >> On 10/11/2018 09:21 PM, Heinrich Schuchardt wrote: >> > >> > On 10/01/2018 08:22 PM, Simon Glass wrote: >> >> Add Kconfig options so that the RTC can be used in SPL and TPL. This is >> >> helpful for accessing the contents of CMOS RAM, for example. >> >> >> >> Signed-off-by: Simon Glass <s...@chromium.org> >> >> Signed-off-by: Simon Glass <s...@chromium.org> >> >> --- >> > >> > Hello Simon, >> > >> > with this patch x86_64 does not boot anymore: >> > $ qemu-system-x86_64 -bios u-boot.rom -nographic --enable-kvm --cpu host >> > ### ERROR ### Please RESET the board ### >> > >> > I am currently testing Bin's patch series: >> > https://patchwork.ozlabs.org/project/uboot/list/?series=70127 >> > [U-Boot,1/4] x86: Specify -march=core2 to build 64-bit U-Boot proper >> > >> >> As a workaround for qemu-x86_defconfig I have sent a patch changing that >> single configuration file. But your patch may have broken more boards. >> > > Thanks for checking. > >> https://lists.denx.de/pipermail/u-boot/2018-October/344137.html >> x86: qemu: enable CONFIG_SPL_DM_RTC > > Simon, can you take a look at this? Whether I should take Heinrich's > patch directly, or you will re-work the original RTC patch?
I think Heinrich's patch is good. I don't believe any boards that use DM_RTC are using it in SPL. My reasoning is that this line would likely cause a build error for such boards, since they probably don't use DT: + .post_bind = dm_scan_fdt_dev, Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
