On 09/30/2018 04:38 PM, Tom Rini wrote:
> As observed with clang:
> lib/efi_loader/efi_boottime.c:1624:7: warning: variable 'info'
> is used uninitialized whenever 'if' condition is true
> [-Wsometimes-uninitialized]
> if (ret != EFI_SUCCESS)
> ^~~~~~~~~~~~~~~~~~
> lib/efi_loader/efi_boottime.c:1653:7: note: uninitialized use
> occurs here
> free(info);
> ^~~~
> lib/efi_loader/efi_boottime.c:1624:3: note: remove the 'if' if
> its condition is always false
> if (ret != EFI_SUCCESS)
> ^~~~~~~~~~~~~~~~~~~~~~~
> lib/efi_loader/efi_boottime.c:1602:31: note: initialize the
> variable 'info' to silence this warning
> struct efi_loaded_image *info;
> ^
> = NULL
>
> Rather than change how we unwind the function it makes the most sense to
> initialize info to NULL so that we can continue to pass it to free().
>
> Fixes: c982874e930d ("efi_loader: refactor efi_setup_loaded_image()")
> Cc: Heinrich Schuchardt <xypron.g...@gmx.de>
> Cc: Alexander Graf <ag...@suse.de>
> Signed-off-by: Tom Rini <tr...@konsulko.com>
Reviewed-by: Heinrich Schuchardt <xypron.g...@gmx.de>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
