On 09/12/2018 06:36 AM, Simon Goldschmidt wrote:
>
>
> Marek Vasut <ma...@denx.de <mailto:ma...@denx.de>> schrieb am Mi., 12.
> Sep. 2018, 02:07:
>
> On 09/12/2018 02:05 AM, Dalon L Westergreen wrote:
> > On Wed, 2018-09-12 at 02:03 +0200, Marek Vasut wrote:
> >> On 09/12/2018 01:55 AM, Dalon L Westergreen wrote:
> >> On Tue, 2018-09-11 at 23:55 +0200, Marek Vasut wrote:
> >> On 09/10/2018 07:28 PM, Dalon Westergreen wrote:
> >> The dtb should be embedded in the u-boot-spl image so that
> >> the CONFIG_SPL_TARGET of spl/u-boot-spl.hex includes it.
> >>
> >> This also affects the main u-boot image, so adjust
> >> CONFIG_SPL_FS_LOAD_PAYLOAD_NAME to u-boot,img which now
> >> also includes the dtb.
> >>
> >> Signed-off-by: Dalon Westergreen <dwest...@gmail.com
> <mailto:dwest...@gmail.com> <mailto:dwest...@gmail.com
> <mailto:dwest...@gmail.com>> <mailto:dwest...@gmail.com
> <mailto:dwest...@gmail.com> <mailto:dwest...@gmail.com
> <mailto:dwest...@gmail.com>>>>
> >> ---
> >> configs/socfpga_stratix10_defconfig | 1 +
> >> include/configs/socfpga_stratix10_socdk.h | 2 +-
> >> 2 files changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/configs/socfpga_stratix10_defconfig
> b/configs/socfpga_stratix10_defconfig
> >> index c27985ad43..b6d804f38e 100644
> >> --- a/configs/socfpga_stratix10_defconfig
> >> +++ b/configs/socfpga_stratix10_defconfig
> >> @@ -56,3 +56,4 @@ CONFIG_DM_USB=y
> >> CONFIG_USB_DWC2=y
> >> CONFIG_USB_STORAGE=y
> >> CONFIG_USE_TINY_PRINTF=y
> >> +CONFIG_OF_EMBED=y
> >>
> >> Did make savedefconfig put this here ?
> >>
> >> No, i put it there myself
> >>
> >> You should always run make savedefconfig to update the defconfig
> instead
> >> of ad-hoc hacking the value at random place.
> >
> > i'll fix it and send a new patch. You already accepted patch 1 & 2
> from
> > the series, so i will just send
> > the one.
>
> Also fix the ; and , bits Simon pointed out. And check with him if he
> has some further feedback.
>
>
> No, after discussing this, I'm fine with the change as is. I'll need
> something similar for gen5, I guess...
>
> So:
> Reviewed-by: Simon Goldschmidt <simon.k.r.goldschm...@gmail..com>
OK, thanks
Also, can you both fix your mailer so it does generate proper text email
reply, with zero tabs/spaces between quote markers ('>') ?
--
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
