Dear Michael Zaidman, In message <660c0f821003230315i54c79d5au12377695cb85a...@mail.gmail.com> you wrote: > > Sorry, I meant that this patch is based on the "Serial support > extended up to 6 COMs" patch (See > http://lists.denx.de/pipermail/u-boot/2010-March/068796.html). > > BTW, If one patch depends on another - what is the correct way to > specify this dependency on the e-mail list?
Such patches should be submitted as one series, so dependency is implicitly resolved. Posting a link to a mailing list archive or the message ID (so you can look it up at http://mid.gmane.org/<id>) work fine. > > Also, the implementation violates the POST framework. If you add this > > as POST code, then please fit it into the existing framework, i. e. > > make it compile- and runtime configurable like other POST tests, run > > it as sub-command of the "diag" command (rename the command then), > > and log the results as the other tests. > > > > Strange, it is what I thought I did in the newly added > /post/drivers/serial.c file in this commit. It is possible to run it > via "diag run uart" command and it meets all requirements you > mentioned above. Then what is the "uart[t]est" command needed for? > Also, I had doubt where to place the serial (actually uart) test in > the POST framework. Till now uart tests are located in POST cpu > specific code. This test is not cpu specific, rather 16550 specific. They are locaed in post/cpu/ iff they are CPU specific. Otherfwise they go like any other driver tests in the driver's directory. > So I placed it under post\drivers and defined the uart_post_test > routine as weak in order do not interfere with board specific uart > POST tests. I don't get this. Where is the weak part needed? Either I have only one type of UART (then the weak is not needed as only onedriver is enabled), or I have both "CPU specific" and "generic" (16550 based) UARTs, in which case I eventually might ant to test _both_ of them (then the weak will not work). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Don't tell me how hard you work. Tell me how much you get done. -- James J. Ling _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
