On Thu, Jun 14, 2018 at 11:06 AM, Vasily Khoruzhick <anars...@gmail.com> wrote:
> On Wed, Jun 13, 2018 at 10:29 PM, Jagan Teki <jagannadh.t...@gmail.com> wrote:
>> On Thu, Jun 14, 2018 at 9:01 AM, Vasily Khoruzhick <anars...@gmail.com>
>> wrote:
>>> On Wed, Jun 13, 2018 at 8:23 PM, Chen-Yu Tsai <w...@csie.org> wrote:
>>>
>>>>> + if (priv->cfg->has_reset) {
>>>>> +#ifdef CONFIG_SUNXI_GEN_SUN6I
>>>>
>>>> The "has_reset" field is supposed to deal with this. Is it not working?
>>>
>>> There's no ahb_reset0_cfg in ccm on sun4i and sun5i, so compilation fails
>>> with
>>>
>>> drivers/usb/host/ohci-sunxi.c:96:26: error: 'struct sunxi_ccm_reg' has
>>> no member named 'ahb_reset0_cfg'
>>
>> Add reset0_cfg_off on driver_data for sun6i. and check the same while
>> writing.
>
> I don't think that hardcoding ahb_reset0_cfg offset here is a good
> idea. Using offsetof() isn't possible without ifdef, since
> this field won't be present in struct sunxi_ccm_reg for sun4i and sun5i.
ie reason I've mentioned to add offset field for sun6i, this is what
we do with phyctl_offset in phy driver. I won't recommend #ifdef
again.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
