On 06/09/2018 12:29 PM, Ramon Fried wrote: > On Sat, Jun 9, 2018 at 1:12 PM, Heinrich Schuchardt <xypron.g...@gmx.de> > wrote: >> On 06/09/2018 01:06 PM, Ramon Fried wrote: >>> The Shared Memory Manager driver implements an interface for allocating >>> and accessing items in the memory area shared among all of the >>> processors in a Qualcomm platform. >>> >>> Adapted from the Linux driver (4.17) >> >> Please, run scripts/checkpatch on this patch an fix all errors and >> warnings, e.g. > Hi Heinrich, > Actually I did run it, and I also run it in Linux and got the same results. > I thought it will be better to keep the driver aligned to Linux than > to fix these warnings. > But if can surely fix it, what do you suggest ?
At least add a comment in the commit message why you diverge from our coding standard. As Mateusz will be the maintainer he should decide. Best regards Heinrich _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
