On 24.05.18 16:57, Tuomas Tynkkynen wrote: > Hi Alex, > > On Thu, 24 May 2018 09:51:57 +0200 > Alexander Graf <ag...@suse.de> wrote: > >> On 20.04.18 12:03, Tuomas Tynkkynen wrote: >>> The magic value that disables relocation is dependent on the CPU word >>> size, so the current 'ffffffff' is doing the wrong thing on aarch64. >>> >>> Signed-off-by: Tuomas Tynkkynen <tuo...@tuxera.com> >> >> The BCM283x series of SOCs is limited to 32bit address space, so I don't >> quite see why the current (int)-1 is wrong? >> >> > > The comparison for the magic "don't relocate value" is done by parsing > the variable as ulong and then comparing to ~0. So on 64-bit, ffffffff > gets interpreted as literal 0xffffffff limit for the relocation (which > I think in practice is the same as not specifying initrd_high at all > since the end of DRAM is lower than that) instead.
Ouch, that logic is terrible. But it means your patch is correct. I'll apply it. Thanks, Alex _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
