Hi Simon Patman is very helpful and useful! I have sent my patches v2 with patman.
Thanks a lot for your kind help! Yours, Ken -----Original Message----- From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass Sent: 2018年5月24日 0:22 To: Ken Ma Cc: U-Boot Mailing List; Stefan Roese; Wilson Ding; Nadav Haklai; Hua Jing Subject: Re: [EXT] Re: [PATCH 1/4] ata: mvebu: move mvebu sata driver to drivers/ata directory Hi Ken, On 23 May 2018 at 01:06, Ken Ma <m...@marvell.com> wrote: > Dear Simon > > Thanks a lot for your kind help and review. > > Previously I did not use patman and generated my patches as below: > 1. used "git mv arch/arm/mach-mvebu/sata.c drivers/ata/ahci_mvebu.c" to do > the file renaming with makefiles and Kconfig file updating. > 2. After the 4 patches are all finished, I used "git format-patch -4 > --cover-letter -o outgoing/sata" to generate the patch set with cover letter. > 3. I used " git send-email --to u-boot@lists.denx.de outgoing/sata* --force" > to send out patches. > > And I try to use patman as your advice, I find that the patch generated by > "patman" can indicate the file "rename" relationship while the patch > generated by "git format-patch" can not. > arch/arm/mach-mvebu/Makefile | 1 - > drivers/ata/Kconfig | 9 +++++++++ > drivers/ata/Makefile | 1 + > arch/arm/mach-mvebu/sata.c => drivers/ata/ahci_mvebu.c | 6 +++--- > 4 files changed, 13 insertions(+), 4 deletions(-) > rename arch/arm/mach-mvebu/sata.c => drivers/ata/ahci_mvebu.c (89%) > … > diff --git a/arch/arm/mach-mvebu/sata.c b/drivers/ata/ahci_mvebu.c > similarity index 89% > rename from arch/arm/mach-mvebu/sata.c > rename to drivers/ata/ahci_mvebu.c > index 5d8032b..5c1b293 100644 > --- a/arch/arm/mach-mvebu/sata.c > +++ b/drivers/ata/ahci_mvebu.c > @@ -1,15 +1,15 @@ > /* > + * Copyright (C) 2018 Marvell International Ltd. > * Copyright (C) 2016 Stefan Roese <s...@denx.de> > * > - * SPDX-License-Identifier: GPL-2.0+ > + * SPDX-License-Identifier: GPL-2.0+ > + * https://spdx.org/licenses > */ > > #include <common.h> > #include <ahci.h> > #include <dm.h> > > -DECLARE_GLOBAL_DATA_PTR; > - > /* > * Dummy implementation that can be overwritten by a board > * specific function > > But I failed to send out patches by patman as below, it says " Alias 'ata' > not found ". > ken@mshsrv05:~/git_ken/u-boot/u-boot$ tools/patman/patman -c4 > Cleaned 4 patches > 0 errors, 1 warnings, 0 checks for > 0001-ata-mvebu-move-mvebu-sata-driver-to-drivers-ata-dire.patch: > <unknown>:0: warning: added, moved or deleted file(s), does > MAINTAINERS need updating? > > checkpatch.pl found 0 error(s), 1 warning(s), 0 checks(s) > Traceback (most recent call last): > File "tools/patman/patman", line 161, in <module> > options.add_maintainers) > File "/home/ken/git_ken/u-boot/u-boot/tools/patman/series.py", line > 231, in MakeCcFile > raise_on_error=raise_on_error) > File "/home/ken/git_ken/u-boot/u-boot/tools/patman/gitutil.py", > line 326, in BuildEmailList > raw += LookupEmail(item, alias, raise_on_error=raise_on_error) > File "/home/ken/git_ken/u-boot/u-boot/tools/patman/gitutil.py", > line 503, in LookupEmail > raise ValueError(msg) > ValueError: Alias 'ata' not found > > > Thanks a lot for your kind help! You can use the -t flag to ignore the missing alias. Regards, Simon > > Yours, > Ken > > > -----Original Message----- > From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass > Sent: 2018年5月23日 7:30 > To: Ken Ma > Cc: U-Boot Mailing List; Stefan Roese > Subject: [EXT] Re: [PATCH 1/4] ata: mvebu: move mvebu sata driver to > drivers/ata directory > > External Email > > ---------------------------------------------------------------------- > Hi Ken, > > On 17 May 2018 at 19:27, <m...@marvell.com> wrote: >> From: Ken Ma <m...@marvell.com> >> >> Currently mvebu sata driver is in arch/arm/mach_mvebu directory, this >> patch moves it to drivers/ata directory with renaming "sata.c" to >> "ahci_mvebu.c" which is aligned to Linux. >> New ahci driver's kconfig option is added as AHCI_MVEBU which selects >> DM_SCSI. >> >> Signed-off-by: Ken Ma <m...@marvell.com> >> Cc: Simon Glass <s...@chromium.org> >> Cc: Stefan Roese <s...@denx.de> >> --- >> arch/arm/mach-mvebu/Makefile | 1 - >> arch/arm/mach-mvebu/sata.c | 54 >> -------------------------------------------- >> drivers/ata/Kconfig | 9 ++++++++ >> drivers/ata/Makefile | 1 + >> drivers/ata/ahci_mvebu.c | 54 >> ++++++++++++++++++++++++++++++++++++++++++++ >> 5 files changed, 64 insertions(+), 55 deletions(-) >> delete mode 100644 arch/arm/mach-mvebu/sata.c >> create mode 100644 drivers/ata/ahci_mvebu.c >> > > How come this doesn't show up as a file move? Are you using patman to > generate your patches? > > Regards, > Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
