Hi Andreas, On 30 March 2018 at 22:27, Andreas Färber <afaer...@suse.de> wrote: > Hi guys, > > Am 30.03.2018 um 10:41 schrieb Simon Glass: >> On 30 March 2018 at 15:53, Neil Armstrong <narmstr...@baylibre.com> wrote: >>> On 30/03/2018 00:41, Simon Glass wrote: >>>> On 29 March 2018 at 16:42, Neil Armstrong <narmstr...@baylibre.com> wrote: >>>>> On 03/12/2017 10:17, Beniamino Galvani wrote: >>>>>> + >>>>>> + gate = &gates[clk->id]; >>>>>> + >>>>>> + if (gate->reg == 0) >>>>>> + return -ENOENT; >>>>> >>>>> Same here -ENOSYS >>> >>> Here thsi means it's not a gate. >> >> Yes, but the driver still supports the operation. The problem is that >> its inputs are invalid. So use -ENOENT to mean that. > > Isn't that the definition of -EINVAL?
We tend to use that to indicate a failure to read the DT config. I should probably not have said 'invalid'. The input value is reasonable (it isn't -ve, for example) but the selected item does not exist. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
