On Sat, Feb 03, 2018 at 10:12:41AM -0700, Simon Glass wrote: > Hi Tom, > > On 26 January 2018 at 17:50, Tom Rini <tr...@konsulko.com> wrote: > > On Fri, Jan 26, 2018 at 02:45:29PM -0700, Simon Glass wrote: > > > >> Hi Tom, > >> > >> Here are some additions to logging and 64-bit sandbox support. > >> > >> > >> The following changes since commit > >> ab12aa24e619b5e81cbde7de88c6d9a19f04313b: > >> > >> ARM: socfpga: Convert callers of cm_write_with_phase for > >> wait_for_bit_le32 (2018-01-26 13:08:03 -0500) > >> > >> are available in the Git repository at: > >> > >> git://git.denx.de/u-boot-dm.git > >> > >> for you to fetch changes up to 4e94617bf911595efcecf52d6c9f323744a81cda: > >> > >> log: add category LOGC_EFI (2018-01-26 12:20:55 -0700) > >> > > > > NAK: > > Starting LLVM-3.8 test > > common/log.c:44:17: warning: implicit conversion from enumeration type > > 'enum log_category_t' to different enumeration type 'enum uclass_id' > > [-Wenum-conversion] > > if (log_uc_cat(cat) >= LOGC_NONE) > > ~~~~~~~~~~ ^~~ > > common/log.c:47:36: warning: implicit conversion from enumeration type > > 'enum log_category_t' to different enumeration type 'enum uclass_id' > > [-Wenum-conversion] > > return uclass_get_name(log_uc_cat(cat)); > > ~~~~~~~~~~ ^~~ > > 2 warnings generated. > > > > Also, checkpatch.pl notes that the sandbox64 defconfig isn't caught by > > MAINTAINERS and then I see the 32bit one already isn't. > > > > Finally, I see a bunch of warnings on sandbox64: > > lib/fdtdec.c: In function ‘fdtdec_get_addr_size_auto_noparent’: > > include/fdtdec.h:27:25: warning: large integer implicitly truncated to > > unsigned type [-Woverflow] > > #define FDT_ADDR_T_NONE (-1ULL) > > > > That's with my normal 64bit host gcc (5.4.0, Ubuntu 16.04). > > OK I'll drop sandbox64 for now. I'm not sure why buildman was happy, > but I may have missed it because there are already a lot of warnings > with sandbox. I'll see if I can fix those. I need to add clang to my > workflow...
It's not too hard. Note that if you go newer than 3.8 there's a ton of warnings I haven't had time to look into. And I only test sandbox with clang atm. -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
