On Mon, Jan 15, 2018 at 11:19 AM, Dr. Philipp Tomsich <philipp.toms...@theobroma-systems.com> wrote: > Tom, > >> On 15 Jan 2018, at 11:06, Mario Six <mario....@gdsys.cc> wrote: >> >> Fix a mis-indented function call in clk_fixed_rate.c > > A general question: do we want to have such gardening commits > create an additional indirection in our history for people using > git-blame frequently (e.g. I usually use git-blame to find the last > commit that touched a line and then read the log message to find > out why something was changed… now I’d have to restart this > search whenever I hit a pure formatting change)? > > My gut feeling would be that we should try to change lines only > when there is an actual change to the code happening. >
From https://www.denx.de/wiki/U-Boot/Patches: "Non-functional changes, i.e. whitespace and reformatting changes, should be done in separate patches marked as cosmetic. This separation of functional and cosmetic changes greatly facilitates the review process." (granted, I didn't explicitly mark the patches as cosmetic) I read that as a general permission to post style-fix patches. If there's a different consensus, I'd like the page modified accordingly. > Regards, > Philipp. > Best regards, Mario >> >> Reviewed-by: Simon Glass <s...@chromium.org> >> Signed-off-by: Mario Six <mario....@gdsys.cc> >> --- >> >> v1 -> v2: >> None >> >> --- >> drivers/clk/clk_fixed_rate.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/clk_fixed_rate.c b/drivers/clk/clk_fixed_rate.c >> index 63565b6ed8..9dd6bc5726 100644 >> --- a/drivers/clk/clk_fixed_rate.c >> +++ b/drivers/clk/clk_fixed_rate.c >> @@ -31,8 +31,8 @@ const struct clk_ops clk_fixed_rate_ops = { >> static int clk_fixed_rate_ofdata_to_platdata(struct udevice *dev) >> { >> #if !CONFIG_IS_ENABLED(OF_PLATDATA) >> - to_clk_fixed_rate(dev)->fixed_rate = dev_read_u32_default(dev, >> - "clock-frequency", 0); >> + to_clk_fixed_rate(dev)->fixed_rate = >> + dev_read_u32_default(dev, "clock-frequency", 0); >> #endif >> >> return 0; >> -- >> 2.11.0 >> > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
