Hi,
Some small coding style remarks below.
2010/1/7 Vipin KUMAR <vipin.ku...@st.com>:
>
> Signed-off-by: Vipin <vipin.ku...@st.com>
> ---
> drivers/serial/usbtty.h | 2 +
> drivers/usb/gadget/Makefile | 1 +
> drivers/usb/gadget/spr_udc.c | 1004
> ++++++++++++++++++++++++++++++++++++++++++
> include/configs/spear.h | 7 +-
> include/usb/spr_udc.h | 227 ++++++++++
> 5 files changed, 1240 insertions(+), 1 deletions(-)
> mode change 100644 => 100755 drivers/serial/usbtty.h
> mode change 100644 => 100755 drivers/usb/gadget/Makefile
> create mode 100755 drivers/usb/gadget/spr_udc.c
> create mode 100755 include/usb/spr_udc.h
> + for (i = 0; i < nb; i++) {
> + writeb(readb(fifo_ptr), bytp);
> + fifo_ptr++;
> + bytp++;
> + }
> + readl(&outep_regs_p[epNum].write_done);
> +
> + return 0;
> +}
> +
> +static void usbputpcktofifo(int epNum, u8 * bufp, u32 len)
Should be u8 *bufp. remove the extra space
Same comment for usbgetpckfromfifo() routine
> +
> + /* SetInterface command received */
> + if (readl(&udc_regs_p->dev_int) & DEV_INT_SETINTF) {
> + writel(DEV_INT_SETINTF, &udc_regs_p->dev_int);
> + }
No brackets for single statement blocks
> + /* USB Start-Of-Frame detected on cable */
> + if (readl(&udc_regs_p->dev_int) & DEV_INT_SOF) {
> + writel(DEV_INT_SOF, &udc_regs_p->dev_int);
> + }
No brackets for single statement blocks
That's all, so after fixing these issues:
Acked-by: Remy Bohmer <li...@bohmer.net>
I suggest the series are being kept together, so Tom do you take it
in your tree?
Kind regards,
Remy
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
