On Thu, 2010-01-07 at 17:26 +0530, Vipin KUMAR wrote: > This patch set is a reworked patch which incorporates all review feedbacks > from > earlier earlier mails > > This patch set contains the support for 4 SoCs > SPEAr600 > SPEAr300 > SPEAr310 > SPEAr320 > > SPEAr is an ARM based SoC which supports rich set of peripherals like > Ethernet, > USB Host, USB Device etc to support various general applications > > For further info on SPEAr SoC, please see README.spear also contained in the > patch set. > > Vipin (9): > Added README.spear > SPEAr600 SoC support added > SPEAr300 SoC support added > SPEAr310 SoC support added > SPEAr320 SoC support added > i2c driver support for SPEAr SoCs > smi driver support for SPEAr SoCs > nand(fsmc) driver support for SPEAr SoCs > usbd driver support for SPEAr SoCs
It would be nice if you reordered the patches. At a glance, some of the boards added first rely on drivers added later. Eg patch 1 uses the I2C driver in patch 6. This will cause 'git bisects' to break. To prevent this you should add SOC + driver code first, then boards last. Something like: 1. Initial SPEAr SOC support 2. SPEAr: Add I2C support 3. SPEAr: Add SMI support .... 6. Add SPEAr 600 board support 7. Add SPEAr 300 board support 8. Add SPEAr 310 board support 9. Add SPEAr 320 board support Best, Peter _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
