On Thu, Sep 21, 2017 at 07:48:20AM +0000, Icenowy Zheng wrote: > > > 于 2017年9月21日 GMT+08:00 下午3:40:23, Maxime Ripard > <maxime.rip...@free-electrons.com> 写到: > >Hi, > > > >On Wed, Sep 20, 2017 at 04:18:19PM +0000, Icenowy Zheng wrote: > >> The sunxi DE1 video option used to be CONFIG_VIDEO, which has the > >same > >> name as the "Enable legacy video support" option in > >> drivers/video/Kconfig. > >> > >> Change the option name to CONFIG_VIDEO_SUNXI, which is really used by > >> Makefile under drivers/video/sunxi/, and defined in sunxi-common.h > >> when CONFIG_VIDEO is selected before this change. Now > >CONFIG_VIDEO_SUNXI > >> selects CONFIG_VIDEO and the usages of CONFIG_VIDEO in sunxi Kconfig > >and > >> config headers are all converted to use CONFIG_VIDEO_SUNXI. > >> > >> Signed-off-by: Icenowy Zheng <icen...@aosc.io> > > > >The patch is fine, but you also seem to imply that it's an issue. It's > >not, you can very well define in Kconfig the same symbol in two > >different places, and Kconfig will merge the two by itself. > > So I can drop this patch and simply add "imply VIDEO_DT_SIMPLEFB" in > the VIDEO option at sunxi Kconfig?
I don't see anything wrong with this patch, there's no need to change it. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
