于 2017年9月21日 GMT+08:00 下午3:40:23, Maxime Ripard <maxime.rip...@free-electrons.com> 写到: >Hi, > >On Wed, Sep 20, 2017 at 04:18:19PM +0000, Icenowy Zheng wrote: >> The sunxi DE1 video option used to be CONFIG_VIDEO, which has the >same >> name as the "Enable legacy video support" option in >> drivers/video/Kconfig. >> >> Change the option name to CONFIG_VIDEO_SUNXI, which is really used by >> Makefile under drivers/video/sunxi/, and defined in sunxi-common.h >> when CONFIG_VIDEO is selected before this change. Now >CONFIG_VIDEO_SUNXI >> selects CONFIG_VIDEO and the usages of CONFIG_VIDEO in sunxi Kconfig >and >> config headers are all converted to use CONFIG_VIDEO_SUNXI. >> >> Signed-off-by: Icenowy Zheng <icen...@aosc.io> > >The patch is fine, but you also seem to imply that it's an issue. It's >not, you can very well define in Kconfig the same symbol in two >different places, and Kconfig will merge the two by itself.
So I can drop this patch and simply add "imply VIDEO_DT_SIMPLEFB" in the VIDEO option at sunxi Kconfig? > >> --- >> arch/arm/mach-sunxi/Kconfig | 29 +++++++++++++++-------------- >> include/configs/sunxi-common.h | 6 ++---- >> scripts/config_whitelist.txt | 1 - >> 3 files changed, 17 insertions(+), 19 deletions(-) >> >> diff --git a/arch/arm/mach-sunxi/Kconfig >b/arch/arm/mach-sunxi/Kconfig >> index 2309f59999..3c29fc61f7 100644 >> --- a/arch/arm/mach-sunxi/Kconfig >> +++ b/arch/arm/mach-sunxi/Kconfig >> @@ -606,7 +606,7 @@ config AXP_GPIO >> ---help--- >> Say Y here to enable support for the gpio pins of the axp PMIC ICs. >> >> -config VIDEO >> +config VIDEO_SUNXI >> bool "Enable graphical uboot console on HDMI, LCD or VGA" >> depends on !MACH_SUN8I_A83T >> depends on !MACH_SUNXI_H3_H5 >> @@ -614,6 +614,7 @@ config VIDEO >> depends on !MACH_SUN8I_V3S >> depends on !MACH_SUN9I >> depends on !MACH_SUN50I >> + select VIDEO >> default y > >Which means that this was just adding depends on and default to the >existing CONFIG_VIDEO in drivers/video/Kconfig. > >Maxime _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
