memset(newpart, '\0', sizeof(newpart));
only initializes the firest 4 or 8 bytes of *newpart and not the whole
structure disk_part.

We should use sizeof(struct disk_part).

Identified by cppcheck.

Fixes: 09a49930e41 GPT: read partition table from device into a data structure
Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
---
 cmd/gpt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cmd/gpt.c b/cmd/gpt.c
index 638aa19826..a9c562123f 100644
--- a/cmd/gpt.c
+++ b/cmd/gpt.c
@@ -190,10 +190,10 @@ static void del_gpt_info(void)
 static struct disk_part *allocate_disk_part(disk_partition_t *info, int 
partnum)
 {
        struct disk_part *newpart;
-       newpart = malloc(sizeof(*newpart));
+       newpart = malloc(sizeof(struct disk_part));
        if (!newpart)
                return ERR_PTR(-ENOMEM);
-       memset(newpart, '\0', sizeof(newpart));
+       memset(newpart, '\0', sizeof(struct disk_part));
 
        newpart->gpt_part_info.start = info->start;
        newpart->gpt_part_info.size = info->size;
-- 
2.11.0

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to