> -----Original Message----- > From: Dirk Behme [mailto:dirk.be...@googlemail.com] > Sent: Wednesday, November 18, 2009 2:07 PM > To: Hiremath, Vaibhav > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH] OMAP3EVM: Added NAND support > > > It would have been nice if subject had a 'v2' now. > [Hiremath, Vaibhav] Ok.
> hvaib...@ti.com wrote: > > From: Vaibhav Hiremath <hvaib...@ti.com> > > Patch description missing here now. And if you re-add, it would be > good to mention that you switch from ONENAND to NAND, too. > [Hiremath, Vaibhav] Will add the description accordingly and submit 'v3'. > > Signed-off-by: Vaibhav Hiremath <hvaib...@ti.com> > > --- > > include/configs/omap3_evm.h | 10 +++++++++- > > 1 files changed, 9 insertions(+), 1 deletions(-) > > > > diff --git a/include/configs/omap3_evm.h > b/include/configs/omap3_evm.h > > index a5514ae..fbc45dc 100644 > > --- a/include/configs/omap3_evm.h > > +++ b/include/configs/omap3_evm.h > > @@ -110,7 +110,8 @@ > > > > #define CONFIG_CMD_I2C /* I2C serial bus support */ > > #define CONFIG_CMD_MMC /* MMC support */ > > -#define CONFIG_CMD_ONENAND /* ONENAND support */ > > +/*#define CONFIG_CMD_ONENAND*/ /* ONENAND support */ > > +#define CONFIG_CMD_NAND /* NAND support */ > > Often it can be irritating for users if default changes silently. > But > EVM people have to discuss about this, I can't say what the > preferred > NAND support is. > [Hiremath, Vaibhav] If we don't get any objection/comments for this change, then I think it should be safe to change to NAND support by default. > > #define CONFIG_CMD_DHCP > > #define CONFIG_CMD_PING > > > > @@ -141,6 +142,7 @@ > > /* to access */ > > /* nand at CS0 */ > > > > + > > What's this? [Hiremath, Vaibhav] Will remove in next version. Thanks Dirk for reviewing this patch. Thanks, Vaibhav > > Best regards > > Dirk > > > #define CONFIG_SYS_MAX_NAND_DEVICE 1 /* Max number > of */ > > /* NAND devices */ > > #define CONFIG_SYS_64BIT_VSPRINTF /* needed for > nand_util.c */ > > @@ -268,7 +270,13 @@ > > #define CONFIG_SYS_MONITOR_BASE CONFIG_SYS_FLASH_BASE > > #define CONFIG_SYS_ONENAND_BASE ONENAND_MAP > > > > +#if defined(CONFIG_CMD_NAND) > > +#define CONFIG_NAND_OMAP_GPMC > > +#define GPMC_NAND_ECC_LP_x16_LAYOUT 1 > > +#define CONFIG_ENV_IS_IN_NAND 1 > > +#elif defined(CONFIG_CMD_ONENAND) > > #define CONFIG_ENV_IS_IN_ONENAND 1 > > +#endif > > #define ONENAND_ENV_OFFSET 0x260000 /* environment starts > here */ > > #define SMNAND_ENV_OFFSET 0x260000 /* environment starts > here */ > > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
