Hello Tom,
right, a bit outdated knowledge, but at least more then two years ago,
working around this warning would always lead to code increase and
I can't think of a reason why the code can actually fail.
Suppressing the warning seems fine with me.
Regards,
Jeroen
On 05/10/2017 09:26 PM, Tom Rini wrote:
We will see warnings such as:
net/eth_common.c:57:61: warning: data argument not used by format string
[-Wformat-extra-args]
sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);
~~~~~~~~ ^
With clang. In this case we do not want to re-write our code to be less
compact as the above is intentional and readable. Add a comment above
the disabling so that it's clear why we want that warning off.
Signed-off-by: Tom Rini <tr...@konsulko.com>
---
net/Makefile | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/net/Makefile b/net/Makefile
index f03d6083268f..ae54eee5afe0 100644
--- a/net/Makefile
+++ b/net/Makefile
@@ -25,3 +25,8 @@ obj-$(CONFIG_CMD_PING) += ping.o
obj-$(CONFIG_CMD_RARP) += rarp.o
obj-$(CONFIG_CMD_SNTP) += sntp.o
obj-$(CONFIG_CMD_NET) += tftp.o
+
+# Disable this warning as it is triggered by:
+# sprintf(buf, index ? "foo%d" : "foo", index)
+# and this is intentional usage.
+CFLAGS_eth_common.o += -Wno-format-extra-args
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
