On Saturday 31 October 2009 18:20:06 Menon, Nishanth wrote: > From: Mike Frysinger > > On Saturday 31 October 2009 10:12:01 Nishanth Menon wrote: > > > +if [ ! -z "$ARCH" -a "$ARCH" != "$2" ]; then > > > > is the !-z really needed ? > > We don't want the check to trigger if ARCH is not defined. > [ "$ARCH" != "$2" ] will trigger as "" != "arm"
the implied question is whether this is a valid state. i know you dont want that kind of comparison, but i thought the Makefile would have set it up for you by default. now that i think about it a bit more, that isnt what happens at all. so only thing to change here is to use -n and not !-z -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
