> -----Original Message-----
> From: Mike Frysinger [mailto:vap...@gentoo.org]
> Sent: Saturday, October 31, 2009 11:41 PM
> To: u-boot@lists.denx.de
> Cc: Menon, Nishanth; Gadiyar, Anand
> Subject: Re: [U-Boot] [PATCH] mkconfig: deny messed up ARCH definition
>
> On Saturday 31 October 2009 10:12:01 Nishanth Menon wrote:
> > Refuse to setup a platform if the command
> > line ARCH= is not the same as the one
> > required for the board. This prevents
> > any user with prehistoric aliases from
> > messing up thier builds
>
> seems like excessive line wrapping
Ok.. will stick with 70 chars..
>
> > +if [ ! -z "$ARCH" -a "$ARCH" != "$2" ]; then
>
> is the !-z really needed ?
We don't want the check to trigger if ARCH is not defined.
[ "$ARCH" != "$2" ] will trigger as "" != "arm"
>
> > + echo "ARCH=$ARCH while ${BOARD_NAME} arch=$2: fail"
>
> should be sent to stderr: 1>&2
Ack.
Regards,
Nishanth Menon
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
