Mike Frysinger wrote:
> On Saturday 31 October 2009 13:37:46 Tom Rix wrote:
>> OMAP3EVM uses ISP1504 phy and so twl4030 related init is not required.
>>
>> --- a/drivers/usb/musb/omap3.c
>> +++ b/drivers/usb/musb/omap3.c
>> @@ -94,12 +94,17 @@ int musb_platform_init(void)
>> if (platform_needs_initialization) {
>> u32 stdby;
>>
>> + /*
>> + * OMAP3EVM uses ISP1504 phy and so
>> + * twl4030 related init is not required.
>> + */
>> +#ifdef CONFIG_TWL4030_USB
>> if (twl4030_usb_ulpi_init()) {
>> serial_printf("ERROR: %s Could not initialize PHY\n",
>> __PRETTY_FUNCTION__);
>> goto end;
>> }
>> -
>> +#endif
>
> shouldnt this be abstracted away (weaks/phy-common name/etc...) instead of
> sprinkling ifdef's everywhere ?
> -mike
I do not think this change has spinkled if-defs' everywhere
As far as I know only the omap3_evm does not use a twl4030.
There is no sense making this more complicated than an if-def.
Tom
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
