Re: [U-Boot] [PATCH 09/10] OMAP3 USB Initialize twl4030 only if required

[Mike Frysinger]

On Saturday 31 October 2009 13:37:46 Tom Rix wrote:
> OMAP3EVM uses ISP1504 phy and so twl4030 related init is not required.
> 
> --- a/drivers/usb/musb/omap3.c
> +++ b/drivers/usb/musb/omap3.c
> @@ -94,12 +94,17 @@ int musb_platform_init(void)
>       if (platform_needs_initialization) {
>               u32 stdby;
> 
> +             /*
> +              * OMAP3EVM uses ISP1504 phy and so
> +              * twl4030 related init is not required.
> +              */
> +#ifdef CONFIG_TWL4030_USB
>               if (twl4030_usb_ulpi_init()) {
>                       serial_printf("ERROR: %s Could not initialize PHY\n",
>                               __PRETTY_FUNCTION__);
>                       goto end;
>               }
> -
> +#endif

shouldnt this be abstracted away (weaks/phy-common name/etc...) instead of 
sprinkling ifdef's everywhere ?
-mike

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot