Hi Wenyou, On 11 April 2017 at 23:00, Yang, Wenyou <wenyou.y...@microchip.com> wrote: > Hi Simon, > > > On 2017/4/11 21:56, Simon Glass wrote: >> >> Hi, >> >> On 10 April 2017 at 00:57, Yang, Wenyou <wenyou.y...@microchip.com> wrote: >>> >>> Hi Simon, >>> >>> >>> On 2017/4/10 3:28, Simon Glass wrote: >>>> >>>> +Tom >>>> >>>> Hi, >>>> >>>> On 7 April 2017 at 01:28, Yang, Wenyou <wenyou.y...@microchip.com> >>>> wrote: >>>>> >>>>> Hi Andreas, >>>>> >>>>> Could you help find a time to take these patch series? >>>>> >>>>> They are here for a long time. >>>>> >>>> Tom might be able to take it, or if not I could bring it in via DM I >>>> suppose, since it is a conversion. >>> >>> >>> I truly appreciate you if you take these patches. >> >> OK I've assigned these to myself in patchwork and will pick them up at >> some point. > > > Thank you very much. > Any question, please let me know. > >> >> Andreas, please feel free to grab these yourself if you like.
I picked these up and pushed to u-boot-dm/testing but got various merge conflicts and the build error below. Can you please take a look and resend the series? 04: board: sama5d4_xplained: clean up code - at91_set_pio_output(AT91_PIO_PORTC, 3, 0); - at91_set_a_periph(AT91_PIO_PORTC, 0, 0); /* SPI0_MISO */ -board/atmel/sama5d4_xplained/built-in.o: In function `sama5d4_xplained_macb0_hw_init': -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:244: undefined reference to `at91_set_a_periph' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:245: undefined reference to `at91_set_a_periph' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:246: undefined reference to `at91_set_a_periph' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:247: undefined reference to `at91_set_a_periph' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:248: undefined reference to `at91_set_a_periph' -board/atmel/sama5d4_xplained/built-in.o:build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:249: more undefined references to `at91_set_a_periph' follow -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:262: undefined reference to `at91_set_b_periph' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:263: undefined reference to `at91_set_b_periph' -board/atmel/sama5d4_xplained/built-in.o: In function `sama5d4_xplained_spi0_hw_init': -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:54: undefined reference to `at91_set_pio_output' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:87: undefined reference to `at91_set_a_periph' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:88: undefined reference to `at91_set_a_periph' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:89: undefined reference to `at91_set_a_periph' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:90: undefined reference to `at91_set_a_periph' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:91: undefined reference to `at91_set_a_periph' -board/atmel/sama5d4_xplained/built-in.o:build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:92: more undefined references to `at91_set_a_periph' follow -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:107: undefined reference to `at91_set_pio_output' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:108: undefined reference to `at91_set_pio_output' + at91_set_a_periph(AT91_PIO_PORTC, 5, 0); /* D0 */ + at91_set_pio_output(AT91_PIO_PORTE, 11, 1); +build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:170: undefined reference to `at91_set_b_periph' +build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:171: undefined reference to `at91_set_b_periph' +build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:53: undefined reference to `at91_set_a_periph' +build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:54: undefined reference to `at91_set_a_periph' +board/atmel/sama5d4_xplained/built-in.o:build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:55: more undefined references to `at91_set_a_periph' follow +build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:70: undefined reference to `at91_set_pio_output' +build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:71: undefined reference to `at91_set_pio_output' w-../board/atmel/sama5d4_xplained/sama5d4_xplained.c: In function 'spi_cs_activate': w-../board/atmel/sama5d4_xplained/sama5d4_xplained.c:40:2: warning: implicit declaration of function 'at91_set_pio_output' [-Wimplicit-function-declaration] w-../board/atmel/sama5d4_xplained/sama5d4_xplained.c: In function 'sama5d4_xplained_spi0_hw_init': w-../board/atmel/sama5d4_xplained/sama5d4_xplained.c:262:2: warning: implicit declaration of function 'at91_set_b_periph' [-Wimplicit-function-declaration] w+../board/atmel/sama5d4_xplained/sama5d4_xplained.c: In function 'sama5d4_xplained_nand_hw_init': w+../board/atmel/sama5d4_xplained/sama5d4_xplained.c: In function 'sama5d4_xplained_usb_hw_init': w+../board/atmel/sama5d4_xplained/sama5d4_xplained.c:70:2: warning: implicit declaration of function 'at91_set_pio_output' [-Wimplicit-function-declaration] w+../board/atmel/sama5d4_xplained/sama5d4_xplained.c:170:2: warning: implicit declaration of function 'at91_set_b_periph' [-Wimplicit-function-declaration] 05: board: sama5d4_xplained: enable early debug UART -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:170: undefined reference to `at91_set_b_periph' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:171: undefined reference to `at91_set_b_periph' -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:50: undefined reference to `at91_set_a_periph' -board/atmel/sama5d4_xplained/built-in.o:build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:55: more undefined references to `at91_set_a_periph' follow -build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:70: undefined reference to `at91_set_pio_output' +build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:172: undefined reference to `at91_set_b_periph' +build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:173: undefined reference to `at91_set_b_periph' +build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:55: undefined reference to `at91_set_a_periph' +board/atmel/sama5d4_xplained/built-in.o:build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:56: more undefined references to `at91_set_a_periph' follow +build/../board/atmel/sama5d4_xplained/sama5d4_xplained.c:72: undefined reference to `at91_set_pio_output' w-../board/atmel/sama5d4_xplained/sama5d4_xplained.c:50:2: warning: implicit declaration of function 'at91_set_a_periph' [-Wimplicit-function-declaration] w-../board/atmel/sama5d4_xplained/sama5d4_xplained.c:70:2: warning: implicit declaration of function 'at91_set_pio_output' [-Wimplicit-function-declaration] w-../board/atmel/sama5d4_xplained/sama5d4_xplained.c:170:2: warning: implicit declaration of function 'at91_set_b_periph' [-Wimplicit-function-declaration] w+../board/atmel/sama5d4_xplained/sama5d4_xplained.c:51:2: warning: implicit declaration of function 'at91_set_a_periph' [-Wimplicit-function-declaration] w+../board/atmel/sama5d4_xplained/sama5d4_xplained.c:71:2: warning: implicit declaration of function 'at91_set_pio_output' [-Wimplicit-function-declaration] w+../board/atmel/sama5d4_xplained/sama5d4_xplained.c:172:2: warning: implicit declaration of function 'at91_set_b_periph' [-Wimplicit-function-declaration] Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
