Hi Maxime,
Thank you for all your reviews!
On 29/03/2017 10:12, Maxime Ripard wrote:
Hi,
On Wed, Mar 29, 2017 at 09:26:37AM +0200, Mylène Josserand wrote:
Convert the CONS_INDEX configuration to Kconfig.
Update sunxi's defconfigs to remove SYS_EXTRA_OPTIONS variable not
needed anymore.
Default value is 1 except for sun5i (equals 2) and sun8i (equals 5).
Signed-off-by: Mylène Josserand <mylene.josser...@free-electrons.com>
---
board/sunxi/Kconfig | 9 +++++++++
configs/A13-OLinuXinoM_defconfig | 1 -
configs/A13-OLinuXino_defconfig | 1 -
configs/Ampe_A76_defconfig | 1 -
configs/CHIP_defconfig | 1 -
configs/Empire_electronix_d709_defconfig | 1 -
configs/Empire_electronix_m712_defconfig | 1 -
configs/difrnce_dit4350_defconfig | 1 -
configs/ga10h_v1_1_defconfig | 1 -
configs/gt90h_v4_defconfig | 1 -
configs/iNet_D978_rev2_defconfig | 1 -
configs/inet86dz_defconfig | 1 -
configs/inet98v_rev2_defconfig | 1 -
configs/polaroid_mid2407pxe03_defconfig | 1 -
configs/polaroid_mid2809pxe04_defconfig | 1 -
configs/q8_a13_tablet_defconfig | 1 -
configs/q8_a23_tablet_800x480_defconfig | 1 -
configs/q8_a33_tablet_1024x600_defconfig | 1 -
configs/q8_a33_tablet_800x480_defconfig | 1 -
include/configs/sunxi-common.h | 4 ----
20 files changed, 9 insertions(+), 22 deletions(-)
Did you rebase on the current sunxi tree recently? There's at least
two boards (CHIP Pro and A23 EVB) that are unfortunately missing from
that least, and whose compilation now will cause a warning :/
I based my series against "next" and these new defconfigs are not
available. Should I rebase my patches against "master" branch?
The CHIP Pro also has a bunch of other (new) options in
SYS_EXTRA_OPTIONS, but you don't have to convert them if you don't
want to.
I will have a look :)
diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
index 9963b6b5d8..706c62d233 100644
--- a/board/sunxi/Kconfig
+++ b/board/sunxi/Kconfig
@@ -157,6 +157,15 @@ config ARM_BOOT_HOOK_RMR
This allows both the SPL and the U-Boot proper to be entered in
either mode and switch to AArch64 if needed.
+config CONS_INDEX
+ int "UART used for console"
+ default 2 if MACH_SUN5I
+ default 5 if MACH_SUN8I
+ default 1
+ help
+ Configures the console index for Allwinner SoC. 2 for SUN5I, 5 for
SUN8I
+ and 1 otherwise.
This is a generic option that is used across a number of platforms,
perhaps this would be better suited to be in drivers/serial (or some
place else?)
Sure, it makes sense.
Once fixed,
Acked-by: Maxime Ripard <maxime.rip...@free-electrons.com>
Thanks!
--
Mylène Josserand, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
