On Sab, 2017-02-25 at 22:41 +0100, Marek Vasut wrote:
> On 02/22/2017 10:47 AM, Ley Foon Tan wrote:
> >
> > Add pinmux support for Arria 10.
> >
> > Signed-off-by: Tien Fong Chee <tien.fong.c...@intel.com>
> > Signed-off-by: Ley Foon Tan <ley.foon....@intel.com>
> > ---
> > arch/arm/mach-socfpga/Makefile | 1 +
> > arch/arm/mach-socfpga/include/mach/pinmux.h | 15 +++++
> > arch/arm/mach-socfpga/pinmux_arria10.c | 98
> > +++++++++++++++++++++++++++++
> > 3 files changed, 114 insertions(+)
> > create mode 100644 arch/arm/mach-socfpga/include/mach/pinmux.h
> > create mode 100644 arch/arm/mach-socfpga/pinmux_arria10.c
> >
> > diff --git a/arch/arm/mach-socfpga/Makefile b/arch/arm/mach-
> > socfpga/Makefile
> > index 9c4617f..68d55e4 100644
> > --- a/arch/arm/mach-socfpga/Makefile
> > +++ b/arch/arm/mach-socfpga/Makefile
> > @@ -12,6 +12,7 @@ obj-y += misc.o timer.o reset_manager.o
> > clock_manager.o \
> >
> > obj-$(CONFIG_TARGET_SOCFPGA_ARRIA10) += clock_manager_arria10.o \
> > misc_arria10.o
> > \
> > + pinmux_arria10.o \
> > reset_manager_arria10.o
> >
> > obj-$(CONFIG_SPL_BUILD) += spl.o freeze_controller.o
> > diff --git a/arch/arm/mach-socfpga/include/mach/pinmux.h
> > b/arch/arm/mach-socfpga/include/mach/pinmux.h
> > new file mode 100644
> > index 0000000..c5d5dd6
> > --- /dev/null
> > +++ b/arch/arm/mach-socfpga/include/mach/pinmux.h
> > @@ -0,0 +1,15 @@
> > +/*
> > + * Copyright (C) 2016-2017 Intel Corporation <www.intel.com>
> > + *
> > + * SPDX-License-Identifier: GPL-2.0
> > + */
> > +
> > +#ifndef _PINMUX_H_
> > +#define _PINMUX_H_
> Use [space] instead of [tab] after #ifdef/#define
Okay.
>
> >
> > +#ifndef __ASSEMBLY__
> > +int config_dedicated_pins(const void *blob);
> > +int config_pins(const void *blob, const char *pin_grp);
> > +#endif
> > +
> > +#endif /* _PINMUX_H_ */
> > diff --git a/arch/arm/mach-socfpga/pinmux_arria10.c
> > b/arch/arm/mach-socfpga/pinmux_arria10.c
> > new file mode 100644
> > index 0000000..04acaa2
> > --- /dev/null
> > +++ b/arch/arm/mach-socfpga/pinmux_arria10.c
> > @@ -0,0 +1,98 @@
> > +/*
> > + * Copyright (C) 2016-2017 Intel Corporation <www.intel.com>
> > + *
> > + * SPDX-License-Identifier: GPL-2.0
> > + */
> > +
> > +#include <common.h>
> > +#include <asm/io.h>
> > +#include <fdtdec.h>
> > +#include <asm/arch/pinmux.h>
> > +
> > +static int do_pinctr_pin(const void *blob, int child, const char
> > *node_name)
> > +{
> > + int len;
> > + fdt_addr_t base_addr;
> > + fdt_size_t size;
> > + const u32 *cell;
> > + u32 offset, value;
> > +
> > + base_addr = fdtdec_get_addr_size(blob, child, "reg",
> > &size);
> > + if (base_addr != FDT_ADDR_T_NONE) {
> > + cell = fdt_getprop(blob, child, "pinctrl-
> > single,pins",
> > + &len);
> > + if (cell != NULL) {
> > + debug("%p %d\n", cell, len);
> > + for (; len > 0; len -= (2*sizeof(u32))) {
> 2 * sizeof(u32) , spacing
Okay.
>
> What about len == 0 , not used ?
Will add the checking for len > 0.
if (cell != NULL && len > 0) {
}
>
> >
> > + offset = fdt32_to_cpu(*cell++);
> > + value = fdt32_to_cpu(*cell++);
> > + debug("<0x%x 0x%x>\n", offset,
> > value);
> > + writel(value, base_addr + offset);
> > + }
> > + return 0;
> > + }
> > + }
> > + return -EFAULT;
> > +}
[...]
Regards
Ley Foon
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/listinfo/u-boot
