Hi Tom,
2017-03-02 6:52 GMT+09:00 Tom Rini <tr...@konsulko.com>:
> From: Masahiro Yamada <yamada.masah...@socionext.com>
>
> Commit 94e3c8c4fd7b ("crypto/fsl - Add progressive hashing support
> using hardware acceleration.") created entries for CONFIG_SHA1,
> CONFIG_SHA256, CONFIG_SHA_HW_ACCEL, and CONFIG_SHA_PROG_HW_ACCEL.
> However, no defconfig has migrated to it. Complete the move with
> moveconfig tool. In many cases we can select these because they are
> required to implement other drivers. We also correct how we include
> the various hashing algorithms in SPL.
>
> This commit was generated as follows:
>
> [1] tools/moveconfig.py -y SHA1 SHA256 SHA_HW_ACCEL
> [2] tools/moveconfig.py -y SHA_PROG_HW_ACCEL
>
> Note:
> We cannot move SHA_HW_ACCEL and SHA_PROG_HW_ACCEL simultaneously
> because there is dependency between them.
>
> Cc: Poonam Aggrwal <poonam.aggr...@freescale.com>
> Cc: Naveen Burmi <naveenbu...@freescale.com>
> Cc: Po Liu <po....@freescale.com>
> Cc: Shengzhou Liu <shengzhou....@freescale.com>
> Cc: Priyanka Jain <priyanka.j...@freescale.com>
> Cc: Shaohui Xie <shaohui....@freescale.com>
> Cc: Chunhe Lan <chunhe....@freescale.com>
> Cc: Chander Kashyap <k.chan...@samsung.com>
> Cc: Steve Rae <steve....@raedomain.com>
> Cc: Dirk Eibach <eib...@gdsys.de>
> Cc: Feng Li <feng.l...@nxp.com>
> Cc: Alison Wang <alison.w...@freescale.com>
> Cc: Sumit Garg <sumit.g...@nxp.com>
> Cc: Mingkai Hu <mingkai...@freescale.com>
> Cc: York Sun <york....@nxp.com>
> Cc: Prabhakar Kushwaha <prabhakar.kushw...@nxp.com>
> Cc: Jaehoon Chung <jh80.ch...@samsung.com>
> Cc: Akshay Saraswat <aksha...@samsung.com>
> Cc: Simon Glass <s...@chromium.org>
> Cc: Heiko Schocher <h...@denx.de>
> Cc: Jagan Teki <ja...@amarulasolutions.com>
> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
> Signed-off-by: Tom Rini <tr...@konsulko.com>
> ---
> Changes in v2:
> - Add a large number of select statements so that our overall delta
> is fairly small. This is not size neutral but is I believe correct.
> We had a number of cases before where we did not enable hw assist in
> the hash command and only made use of it in certain back end locations.
Thanks a lot for arranging and improving this work!
(I also thought about the possible "select", but I was just compromised in v1.)
v2 is OK with me, and it is nicer to use "select" where possible
but I do not have time to check the diffs in v2.
And, I am not comfortable with my Author and Signed-off-by
because most of the efforts were done by you.
(What I did for v1 was just to run the moveconfig.py,
even did not do build-testing.)
So, could you replace the Author/SOB tags with yours?
I am happy to hand it off to anybody who does a better job.
(and I do not require to record that the flag was raised by me)
Also, the git-log:
This commit was generated as follows:
[1] tools/moveconfig.py -y SHA1 SHA256 SHA_HW_ACCEL
[2] tools/moveconfig.py -y SHA_PROG_HW_ACCEL
is no longer valid because v2 includes manual works.
Can you rephrase (or drop) it (in any way you think good).
Again, thank you for taking care of this!
--
Best Regards
Masahiro Yamada
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/listinfo/u-boot
