R, Vignesh wrote: > On 2/28/2017 8:38 PM, Rush, Jason A. wrote: > [...] >> >> This also works. >> >> Marek - how do you feel about a patch series with the following: >> >> 1. revert commit 57897c13de03ac0136d64641a3eab526c6810387 >> spi: cadence_qspi_apb: Use 32 bit indirect write transaction when >> possible >> 2. revert commit b63b46313ed29e9b0c36b3d6b9407f6eade40c8f >> spi: cadence_qspi_apb: Use 32 bit indirect read transaction when >> possible >> 3. Apply my slightly modified version of >> https://patchwork.ozlabs.org/patch/693069/ >> (should I keep Vignesh as the signed-off?) > > Depends on how much you have changed the code. If the change is > significant then change the authorship to you and drop my signed-off. > Else, keep the authorship and signed-off. > If you are adding something new to the patch like adding code to make > sure that only 32bit data reads are issued, then I suggest you to submit > that change as separate patch.
Very minimal. Another commit changed a #define from CQSPI_REG_INDIRECTWR_START_MASK to CQSPI_REG_INDIRECTWR_START, so I had to modify the patch to drop the _MASK so it would apply. Other than that, it's identical in content. > >> 4. Clean-up loading the reg variables to use fdtdec_get_addr_xxx(...) and >> mark >> them all as __iomem >> 5. Load the indirect-trigger property from the DT as a u32. I think this >> still >> needs to be a u32 because it's used in a writel(...) 32-bit write call >> in >> cadence_qspi_apb.c >> 6. Add indirect-trigger to dts files that use cadence driver >> >> I think that captures all the changes needed. >> >> Also, for the naming of the DT property, Linux has uses a 'cdns,' prefix >> (e.g. cdns,trigger-address) for a number of their properties (cdns,tshsl-ns, >> cdns,tsd2d-ns, etc.), but u-boot does not currently use the 'cdns,' prefix >> for >> the same properties. Do you want the 'cdns,' prefix on trigger-address? >> If so, do you want me to rename all the other properties to align them with >> the Linux DT as an additional patch? >> -- Regards, Jason _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/listinfo/u-boot
