Hi, On 17 February 2017 at 10:31, Philipp Tomsich <philipp.toms...@theobroma-systems.com> wrote: > Some architectures require their SPL loader at a fixed address within > the first 16KB of the disk. To avoid an overlap with the partition > entries of the EFI partition table, the first safe offset (in bytes, > from the start of the device) for the entries can be set through > CONFIG_EFI_PARTITION_ENTRIES_OFF. > > When formatting a device with an EFI parition table, we may need to > leave a gap between the GPT header (always in LBA 1) and the partition > entries. The GPT header already contains a field to specify the > on-disk location, which has so far always been set to LBA 2. With this > change, a configurable offset will be translated into a LBA address > indicating where to put the entries. > > Now also allows an override via device-tree using a config-node. > > Tested (exporting an internal MMC formatted with this) against Linux, > MacOS X and Windows. > > Signed-off-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> > --- > disk/part_efi.c | 46 > ++++++++++++++++++++++++++++++++++++++++---- > scripts/config_whitelist.txt | 1 + > 2 files changed, 43 insertions(+), 4 deletions(-)
Looks good to me. But there are a few things to tweak, sorry. Can you please send v2 without all the context lines, and use CONFIG_OF_CONTROL instead of CONFIG_OF_LIBFDT? Also you cannot add new CONFIG options. You should add your new option to a Kconfig file. For your device tree property, that should be documented in 'Configuration Options' in README.fdt-control. Or better if you can send a patch to move that section out of that file into doc/device-tree-bindings/config.txt and then put your new one in there... Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
