Hi Kever, On 13 February 2017 at 02:38, Kever Yang <kever.y...@rock-chips.com> wrote: > > This series patch enable basic driver for rk3399 SPL, the ATF support > has been split as a separate patch. > > SPL_OF_PLATDATA is consider to be must because the dram driver has much > configuration parameter from dts, but we don't want to do the copy.
I still don't think we should be using it on devices which don't need it. For the copy I think you are referring to fdtdec_get_int_array(). I showed you some code that avoids copying and I suspect is just as fast as what you have. Anyway let's compare the two options when you have them. > > Other driver like clock, pinctrl, sdhci has update to support > OF-PLATDATA. > > > Changes in v2: > - use lower-case hex for input dts data > - using rk3288 like style to encode/decode sys_reg > - gather some parameters as base params in rk3399_sdram_params > - add some missing comment > - split SPL patch into 4 patches > > Changes in v1: > - use dts for parameter > - get all controller base address from dts instead of hard code > - gather all controller into dram_info instead of separate global > variables. > - add return value for error case > > Kever Yang (9): > arm64: rk3399: add ddr controller driver > arm64: rk3399: move grf register definitions to grf_rk3399.h > clk: rk3399: update driver for spl > sdhci: rk3399: update driver to support of-platdata > pinctrl: rk3399: add the of-platdata support > arm64: rk3399: syscon addition for rk3399 > dts: rk3399: update for spl require driver > arm64: rk3399: add SPL support > config: rk3399: enable SPL config for evb-rk3399 > > arch/arm/Kconfig | 1 + > arch/arm/dts/rk3399-evb.dts | 2 + > arch/arm/dts/rk3399-sdram-lpddr3-4GB-1600.dtsi | 1536 > +++++++++++++++++++++ > arch/arm/dts/rk3399.dtsi | 44 + > arch/arm/include/asm/arch-rockchip/clock.h | 9 + > arch/arm/include/asm/arch-rockchip/cru_rk3399.h | 5 + > arch/arm/include/asm/arch-rockchip/grf_rk3399.h | 118 ++ > arch/arm/include/asm/arch-rockchip/sdram_rk3399.h | 124 ++ > arch/arm/mach-rockchip/Kconfig | 2 + > arch/arm/mach-rockchip/Makefile | 1 + > arch/arm/mach-rockchip/rk3399-board-spl.c | 158 +++ > arch/arm/mach-rockchip/rk3399/Makefile | 1 + > arch/arm/mach-rockchip/rk3399/clk_rk3399.c | 21 + > arch/arm/mach-rockchip/rk3399/sdram_rk3399.c | 1259 +++++++++++++++++ > arch/arm/mach-rockchip/rk3399/syscon_rk3399.c | 40 + > configs/evb-rk3399_defconfig | 18 + > drivers/clk/rockchip/clk_rk3399.c | 89 +- > drivers/mmc/rockchip_sdhci.c | 17 +- > drivers/pinctrl/rockchip/pinctrl_rk3399.c | 111 +- > include/configs/rk3399_common.h | 11 + > include/dt-bindings/clock/rk3399-cru.h | 16 +- > 21 files changed, 3460 insertions(+), 123 deletions(-) > create mode 100644 arch/arm/dts/rk3399-sdram-lpddr3-4GB-1600.dtsi > create mode 100644 arch/arm/include/asm/arch-rockchip/sdram_rk3399.h > create mode 100644 arch/arm/mach-rockchip/rk3399-board-spl.c > create mode 100644 arch/arm/mach-rockchip/rk3399/sdram_rk3399.c > > -- > 1.9.1 > Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
