On 02/06/2017 02:54 PM, Alex G. wrote: > On 02/06/2017 12:38 PM, Andrew F. Davis wrote: >> On 02/06/2017 02:30 PM, Alex G. wrote: >>> >>> >>> On 02/06/2017 11:47 AM, Andrew F. Davis wrote: >>>> On 02/06/2017 01:02 PM, Alex G. wrote: >>>>> On 02/06/2017 07:56 AM, Andrew F. Davis wrote: >>>>>> On 02/03/2017 05:42 PM, Alexandru Gagniuc wrote: >>>>>>> The Adaptrum ACRS2 mainboard uses a Vitesse VSC8601 PHY. >>>>>>> >>>>>>> Signed-off-by: Alexandru Gagniuc <ale...@adaptrum.com> >>>>>>> --- >>>>>>> include/configs/am335x_evm.h | 1 + >>>>>>> 1 file changed, 1 insertion(+) >>>>>>> >>>>>>> diff --git a/include/configs/am335x_evm.h >>>>>>> b/include/configs/am335x_evm.h >>>>>>> index cd42601..b0014cf 100644 >>>>>>> --- a/include/configs/am335x_evm.h >>>>>>> +++ b/include/configs/am335x_evm.h >>>>>>> @@ -366,6 +366,7 @@ >>>>>>> #define CONFIG_PHY_SMSC >>>>>>> /* Enable Atheros phy driver */ >>>>>>> #define CONFIG_PHY_ATHEROS >>>>>>> +#define CONFIG_PHY_VITESSE >>>>>>> >>>>>> >>>>>> These PHY symbols should instead be moved to Kconfig, lets try not to >>>>>> add anything new to the config headers :) >>>>> >>>>> The whole PHY_ seclection does seem like it could use a major >>>>> rework. I >>>>> was hoping to not have to touch Kconfig in this series, but if that is >>>>> the will, I shall yield. >>>>> >>>> >>>> It's really not so bad, have you ever used tools/moveconfig.py? Just >>>> define the symbol in kconfig and it will do all the work for you. The >>>> more people forced to at least try it out the quicker we can finish >>>> with >>>> this the conversion. >>> >>> I did try this for PHYLIB, and got a bunch of >>> >>> Compiler is missing. Do nothing. >>> >>> I got that for every single defconfig, so I gave up on it. >>> >> >> Yeah, this is the only hard part, you need compilers for each supported >> platform. You can use buildman to grab most of them, my path ends up >> like this: >> >> export >> PATH=~/.buildman-toolchains/blackfin/opt/uClinux/bfin-elf/bin/:~/.buildman-toolchains/gcc-4.2.4-nolibc/avr32-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/aarch64-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/x86_64-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/am33_2.0-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/alpha-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/microblaze-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/hppa-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/m68k-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/powerpc64-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/sparc-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/xtensa-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/s390x-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/ia64-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/frv-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/mips-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/i386-linux/bin/:~/.buildman -toolchains/gcc-4.9.0-nolibc/ppc64le-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/sparc64-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/m32r-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/hppa64-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/powerpc-linux/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/h8300-elf/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/arm-unknown-linux-gnueabi/bin/:~/.buildman-toolchains/gcc-4.9.0-nolibc/mips64-linux/bin/:~/.buildman-toolchains/gcc-4.5.1-nolibc/or32-linux/bin/:~/.buildman-toolchains/arc/arc_gnu_2016.03_prebuilt_uclibc_le_archs_linux_install/bin/:~/.buildman-toolchains/gcc-4.6.2-nolibc/tilegx-linux/bin/:~/.buildman-toolchains/sh/renesas-2012.09/bin/:~/.buildman-toolchains/gcc-4.6.3-nolibc/crisv32-linux/bin/:~/.buildman-toolchains/gcc-4.6.3-nolibc/bfin-uclinux/bin/:~/.buildman-toolchains/gcc-4.6.3-nolibc/cris-linux/bin/:~/.buildman-toolchains/gcc-4.6.3-nolibc/sh4-linux/bin/:$PATH >> > > In conclusion, I think I will define the Kconfig symbols -- note I > didn't say also move the #defines". I'm okay with dropping this patch > (4/5) from the series. >
Nah, I'm not actually expecting this work, like before, just trying to push others to try converting some symbols :) not really a major blocker to me. Andrew >> Then you should be good! > > :) > > Alex > >> Andrew >> >> P.S. I would bundle these all up and send them to you, but it ends up >> being several GB of data... >> >>> Alex >>> >>>> Andrew >>>> >>>>> Alex >>>>> >>>>>> >>>>>> Andrew >>>>>> >>>>>>> /* >>>>>>> * NOR Size = 16 MiB >>>>>>> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
