2017年1月16日 15:59于 Maxime Ripard <maxime.rip...@free-electrons.com>写道：
>
> On Fri, Jan 13, 2017 at 01:30:00AM +0000, Andre Przywara wrote:
> > The Allwinner H5 is very close to the H3 SoC, but has ARMv8 cores.
> > To allow sharing the clocks, GPIO and driver code easily, create an
> > architecture agnostic MACH_SUN8I_H3_H5 Kconfig symbol.
> > Rename the existing symbol to MACH_SUN8I_H3_H5 where code is shared and
> > let it be selected by a new shared Kconfig option.
>
> This isn't really related to sun8i anymore, how about
> MACH_SUNXI_H3_H5?
Agree.
It's once more the sun8i and sun50i naming scheme being weird.
It not only hides the relationship between sun4i(A10) and sun8iw2p1(A20), but
also hides sun8iw7p1(H3) and sun50iw2p1(H5).
>
> [...]
>
> >
> > +__weak void tzpc_init(void)
> > +{
> > +}
> > +
> > void s_init(void)
> > {
> > /*
> > @@ -188,10 +192,9 @@ void s_init(void)
> > "mcr p15, 0, r0, c1, c0, 1\n"
> > ::: "r0");
> > #endif
> > -#if defined CONFIG_MACH_SUN6I || defined CONFIG_MACH_SUN8I_H3
> > - /* Enable non-secure access to some peripherals */
> > +
> > + /* Enable non-secure access to some peripherals (only if needed) */
> > tzpc_init();
> > -#endif
>
> This looks unrelated to your patch.
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
>
> --
> You received this message because you are subscribed to the Google Groups
> "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to linux-sunxi+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
