On 12/04/2016 05:52 PM, Stefan Brüns wrote:
The runner actually has no console dependency, only on the log provided by the console. Accept both u_boot_console or a multiplexed_log.
Either this approach or updating all callers to always pass the log object is fine by me. So if you need it,
Acked-by: Stephen Warren <swar...@nvidia.com> One nit:
diff --git a/test/py/u_boot_utils.py b/test/py/u_boot_utils.py
+ if hasattr(u_boot_console_or_log, 'get_runner'): + get_runner = u_boot_console_or_log.get_runner + else: + get_runner = u_boot_console_or_log.log.get_runner + runner = get_runner(cmd[0], sys.stdout)
+ if hasattr(u_boot_console_or_log, 'get_runner'): + get_runner = u_boot_console_or_log.get_runner + else: + get_runner = u_boot_console_or_log.log.get_runner + runner = get_runner(cmd[0], sys.stdout)
It would be nice to put that into a utility function so as not to duplicate it, if you keep this approach.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
