On Tue, Nov 29, 2016 at 11:42:34AM -0600, Joe Hershberger wrote: > On Tue, Nov 15, 2016 at 11:01 AM, Yann E. MORIN <yann.morin.1...@free.fr> > wrote: > > Joe, All, > > > > On 2016-11-14 21:15 -0600, Joe Hershberger spake thusly: > >> On Sun, Nov 13, 2016 at 2:59 PM, Yann E. MORIN <yann.morin.1...@free.fr> > >> wrote: > >> > Currently, CMD_PXE is forcibly enabled in config_distro_defaults.h, so > >> > that general purpose distributions can rely on it being defined. This > >> > header is included, under conditions or not, by various archs or > >> > famillies of archs / SoCs. > >> > > >> > However, it is very possible that boards based on those SoCs will not > >> > have a physical ethernet connector at all, even if the have a MAC; for > >> > example, the Nanopi Neo AIR (sunxi H3) does not. It is also possible > >> > that network booting is absolutely not necessary for a device. > >> > > >> > However, it is not possible to disable the PXE command, as it is > >> > forcibly enabled and is non-configurable. > >> > > >> > But it turns out we already have a config option to build a distro-ready > >> > image, in the name of DISTRO_DEFAULTS. > >> > > >> > Move CMD_PXE out of the hard-coded config_distro_defaults.h into a > >> > Kconfig option, that gets selected by DISTRO_DEFAULTS when it is set. > >> > > >> > Signed-off-by: "Yann E. MORIN" <yann.morin.1...@free.fr> > >> > Cc: Joe Hershberger <joe.hershber...@ni.com> > >> > >> I like this, but do you not also need to run moveconfig.py on this patch? > > > > Ack. I was not aware of this tool. I will run it and if it does change > > any defconfig, I'll repost. If nothing is changed, I'll just reply to > > this thread. OK? > > Sure. > > > Should the defconfig update be a separate patch, or should it be > > squashed into this one? > > I think most that I have seen it is squashed (though I prefer to > create a real patch first to run it against and squash later - I know > others prefer to run it against a working directory).
So I'm stepping in here. I'm close to being able to take the original patch as-is, the main problems with it were what I addressed in a series earlier today, that MENU and CMD_BOOTMENU need to be migrated and a number of platforms that are using config_distro_defaults.h and config_distro_bootcmd.h but were not enabling CONFIG_DISTRO_DEFAULTS so had lost various features. With these two in, and a minor change to this patch to have it select MENU, everything is good, and I'll take it. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
