Hi Simon, > > Hi Patrick, > > On 24 November 2016 at 03:27, Patrick DELAUNAY > <patrick.delau...@st.com> wrote: > > Hi Simon, > > > >> > >> Hi Patrick, > >> > >> On 22 November 2016 at 06:24, Patrick Delaunay > >> <patrick.delauna...@gmail.com> wrote: > >> > From: Patrick Delaunay <patrick.delau...@st.com> > >> > > >> > Signed-off-by: Patrick Delaunay <patrick.delau...@st.com> > >> > Signed-off-by: Patrick Delaunay <patrick.delauna...@gmail.com> > >> > --- > >> > > >> > Kconfig | 12 ++ > >> > cmd/gpt.c | 98 ++++++++-- > >> > cmd/mtdparts.c | 103 ++++++++++- > >> > cmd/part.c | 48 ++++- > >> > disk/part_efi.c | 526 > >> ++++++++++++++++++++++++++++++++++++++++++++++++----- > >> > doc/README.gpt.mtd | 189 +++++++++++++++++++ > >> > include/part.h | 13 +- > >> > include/uuid.h | 1 + > >> > lib/uuid.c | 33 ++++ > >> > 9 files changed, 944 insertions(+), 79 deletions(-) create mode > >> > 100644 doc/README.gpt.mtd > >> > >> General comments: > >> > >> - use 'U-Boot' consistently rather than variations > >> - can you split your large function up a bit? > >> - can you make a precursor patch to refactor things, so reducing the > >> size of this one? > > > > Yes, I will do this split in v2 to reduce each patch size: > > - one patch to uuid new function > > - one precursor for efi part : refactor > > - one patch for GPT over MTD in part_efi.c > > & I will split large function > > - one patch for each command update > > > >> - nice README! > >> > >> > > >> > diff --git a/Kconfig b/Kconfig > >> > index 1263d0b..c2388e1 100644 > >> > --- a/Kconfig > >> > +++ b/Kconfig > >> > @@ -335,6 +335,18 @@ config ARCH_FIXUP_FDT > >> > > >> > endmenu # Boot images > >> > > >> > +config EFI_PARTITION_MTD > >> > + bool "Support GPT over MTD" > >> > + help > >> > + The GPT partition is normally defined only for block device > >> > with > >> > + built-in controller which manage flash translation layer > >> > + This option activate the GPT partition support over RAW device > >> > + using the MTD framework > >> > + - manage partition over MTD devices (as flash: NOR and NAND) > >> > + - extract MTD information > >> > + - update command gpt, mtdparts and part > >> > + NB: depends on EFI_PARTITION > >> > >> So do you want 'depends on EFI_PARTITION'? > > > > Yes I expect it, I try to add > > depends on EFI_PARTITION > > but is not working as it is not (yet ?) one KCONFIG option. > > I add this comment to add this line when part lib will integrate > > KCONFIG > > I see. Well if you have the energy you could use moveconfig.py to convert it.
I will try to propose something (first usage of moveconfig.py script...) if I have no issue with cross-compilation => Create "disk/Kconfig" with PARTITIONS all associated option (MAC_PARTITION, DOS_PARTITION, ISO_PARTITION, AMIGA_PARTITION, EFI_PARTITION) > Regards, > Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
