Hi Bin, Please see my comment inline.
Thanks, Minghuan > -----Original Message----- > From: Bin Meng [mailto:bmeng...@gmail.com] > Sent: Monday, October 10, 2016 7:42 PM > To: M.H. Lian <minghuan.l...@nxp.com> > Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Mingkai Hu > <mingkai...@nxp.com>; Leo Li <leoyang...@nxp.com> > Subject: Re: [U-Boot] [PATCH 9/9] armv8: ls1046a: Enable PCIe support > > Hi Minghuan, > > On Mon, Oct 10, 2016 at 4:47 PM, Minghuan Lian <minghuan.l...@nxp.com> > wrote: > > Signed-off-by: Minghuan Lian <minghuan.l...@nxp.com> > > --- > > include/configs/ls1046a_common.h | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/include/configs/ls1046a_common.h > > b/include/configs/ls1046a_common.h > > index 7c5e635..f8f5ee2 100644 > > --- a/include/configs/ls1046a_common.h > > +++ b/include/configs/ls1046a_common.h > > @@ -117,6 +117,21 @@ > > #define CONFIG_SYS_I2C_MXC_I2C3 > > #define CONFIG_SYS_I2C_MXC_I2C4 > > > > +/* PCIe */ > > +#define CONFIG_PCI /* Enable PCI/PCIE */ > > +#define CONFIG_DM_PCI /* Enable driver mode for PCI */ > > +#define CONFIG_DM_PCI_COMPAT > > +#define CONFIG_PCIE_LAYERSCAPE /* Use common FSL Layerscape PCIe > code > > +*/ #define CONFIG_SYS_PCI_64BIT > > Please do not add any Kconfig option in the header file any more. > These already converted Kconfig options should be moved to boards' > defconfig files. [Minghuan Lian] Ok. I will move them to defconfig files. > > > + > > +#ifdef CONFIG_PCI > > +#define CONFIG_PCI_PNP > > +#define CONFIG_PCI_SCAN_SHOW > > +#define CONFIG_CMD_PCI > > +#define CONFIG_NET_MULTI > > +#define CONFIG_E1000 > > +#endif > > + > > /* Command line configuration */ > > #define CONFIG_CMD_ENV > > > > -- > > Regards, > Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
