<snip>
> > + switch (ppc440epx_reg[i].address) {
> > + case 0x00b0:
> > + value = mfdcr ( 0x00b0 );
>
> Please drop the spaces around the braces:
>
> value = mfdcr(0x00b0);
>
> Also in the other cases below.
<snip>
> > + case 0x0026:
> > + value = mfdcr ( 0x0026 );
> > + break;
> > + default:
> > + printf ("\nERROR: unknown DCR address: 0x%x\n",
> > + ppc440epx_reg[i].address);
>
> I would prefer the style func(), without a space before the "(". Most of the
> code uses this code, so its more consistent.
I have the same preferences, as do most people I would guess. I
mentioned this preference to someone else who submitted a patch in the
past and they promptly pointed me to
http://www.denx.de/wiki/U-Boot/CodingStyle
Anyone care if I change the part about ""Lindent -pcs" (adding spaces
before parameters to function calls) is actually used." And adding a
reference to Linux's checkpatch.pl script would be nice too.
Best,
Peter
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
