Re: [U-Boot] [PATCH 1/2] power: pmic: lp873x: Add the base pmic support

[Keerthy]

On Tuesday 27 September 2016 06:04 AM, Simon Glass wrote:

Hi,

On 26 September 2016 at 00:00, Keerthy <j-keer...@ti.com> wrote:

Add support to bind the regulators/child nodes with the pmic.

Signed-off-by: Keerthy <j-keer...@ti.com>
---
 drivers/power/pmic/Kconfig  |  7 ++++++
 drivers/power/pmic/Makefile |  1 +
 drivers/power/pmic/lp873x.c | 59 +++++++++++++++++++++++++++++++++++++++++++++
 include/power/lp873x.h      | 19 +++++++++++++++
 4 files changed, 86 insertions(+)
 create mode 100644 drivers/power/pmic/lp873x.c
 create mode 100644 include/power/lp873x.h

diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig
index 92931c5..00fcacb 100644
--- a/drivers/power/pmic/Kconfig
+++ b/drivers/power/pmic/Kconfig
@@ -142,3 +142,10 @@ config PMIC_PALMAS
        ---help---
        The PALMAS is a PMIC containing several LDOs, SMPS.
        This driver binds the pmic children.
+
+config PMIC_LP873X
+       bool "Enable driver for Texas Instruments LP873X PMIC"
+       depends on DM_PMIC
+       ---help---
+       The LP873X is a PMIC containing couple of LDOs and couple of SMPS.
+       This driver binds the pmic children.
diff --git a/drivers/power/pmic/Makefile b/drivers/power/pmic/Makefile
index 828c0cf..334a24f 100644
--- a/drivers/power/pmic/Makefile
+++ b/drivers/power/pmic/Makefile
@@ -16,6 +16,7 @@ obj-$(CONFIG_PMIC_RK808) += rk808.o
 obj-$(CONFIG_PMIC_TPS65090) += tps65090.o
 obj-$(CONFIG_PMIC_S5M8767) += s5m8767.o
 obj-$(CONFIG_$(SPL_)PMIC_PALMAS) += palmas.o
+obj-$(CONFIG_$(SPL_)PMIC_LP873X) += lp873x.o

 obj-$(CONFIG_POWER_LTC3676) += pmic_ltc3676.o
 obj-$(CONFIG_POWER_MAX77696) += pmic_max77696.o
diff --git a/drivers/power/pmic/lp873x.c b/drivers/power/pmic/lp873x.c
new file mode 100644
index 0000000..ace798c
--- /dev/null
+++ b/drivers/power/pmic/lp873x.c
@@ -0,0 +1,59 @@
+/*
+ * (C) Copyright 2016 Texas Instruments Incorporated, <www.ti.com>
+ * Keerthy <j-keer...@ti.com>
+ *
+ * SPDX-License-Identifier:    GPL-2.0+
+ */
+
+#include <common.h>
+#include <fdtdec.h>
+#include <errno.h>
+#include <dm.h>
+#include <i2c.h>
+#include <power/pmic.h>
+#include <power/regulator.h>
+#include <power/lp873x.h>
+#include <dm/device.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+static const struct pmic_child_info pmic_children_info[] = {
+       { .prefix = "ldo", .driver = LP873X_LDO_DRIVER },
+       { .prefix = "buck", .driver = LP873X_BUCK_DRIVER },
+       { },
+};
+
+static int lp873x_bind(struct udevice *dev)
+{
+       int regulators_node;
+       const void *blob = gd->fdt_blob;
+       int children;
+       int node = dev->of_offset;
+
+       regulators_node = fdt_subnode_offset(blob, node, "regulators");
+
+       if (regulators_node <= 0) {
+               printf("%s: %s reg subnode not found!", __func__, dev->name);

These should be debug() I think. We should not be printing things in
drivers. Also it bloats the code for an error condition that should
never happen.

Ah my bad! I should have used debug here. I will fix this.

+               return -ENXIO;
+       }
+
+       children = pmic_bind_children(dev, regulators_node, pmic_children_info);
+       if (!children)
+               printf("%s: %s - no child found\n", __func__, dev->name);
+
+       /* Always return success for this device */
+       return 0;
+}
+
+static const struct udevice_id lp873x_ids[] = {
+       { .compatible = "ti,lp8732", .data = LP8732 },
+       { .compatible = "ti,lp8733" , .data = LP8733 },
+       { }
+};
+
+U_BOOT_DRIVER(pmic_lp873x) = {
+       .name = "lp873x_pmic",
+       .id = UCLASS_PMIC,
+       .of_match = lp873x_ids,
+       .bind = lp873x_bind,
+};
diff --git a/include/power/lp873x.h b/include/power/lp873x.h
new file mode 100644
index 0000000..e0c0711
--- /dev/null
+++ b/include/power/lp873x.h
@@ -0,0 +1,19 @@
+#define        LP8732          0x0
+#define LP8733         0x1
+
+#define LP873X_LDO_NUM         2
+#define LP873X_BUCK_NUM                2
+
+/* Drivers name */
+#define LP873X_LDO_DRIVER      "lp873x_ldo"
+#define LP873X_BUCK_DRIVER     "lp873x_buck"
+
+#define LP873X_BUCK_VOLT_MASK          0xFF
+#define LP873X_BUCK_VOLT_MAX_HEX       0xFF
+#define LP873X_BUCK_VOLT_MAX           3360000
+#define LP873X_BUCK_MODE_MASK          0x1
+
+#define LP873X_LDO_VOLT_MASK    0x1F
+#define LP873X_LDO_VOLT_MAX_HEX 0x19
+#define LP873X_LDO_VOLT_MAX     3300000
+#define LP873X_LDO_MODE_MASK   0x1
--
1.9.1

Regards,
Simon

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot