On Sep 22, 2009, at 2:50 PM, Wolfgang Denk wrote: > Dear Ben Warren, > > In message <f8328f7c0909131022t700abe65p5083bdc3c4630...@mail.gmail.com > > you wrote: >> >>> I always use 'git am -s', which adds the SOB. My understanding >>> is that >> maintainers should do this as an indication of approval and help in >> traceability. > > Please feel free to do that, but I consider this just adding > line-noise, unless you _really_ express special approval. > > Which sense would it make if I added a s-o-b to each and every commit > I'm pulling in from anywhere?
You're not pulling it, you are applying it. And the s-o-b is used to show the paper trail of who has touched it. So all you should need to backtrack the source of the code change is the list of the s-o-bs. S-o-b is not an approval of the technical merits of the change. It's a pure bookkeeping measure to tell where a piece of code came from and who handled it on the way. BUT in addition to this it's really useful for a newbie like me to see who to send a patch to, since it shows the list of maintainership (up to the first person that submits his work through git pulls, but that seems nonexistent for non-maintainers in u-boot anyway :) -Olof _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
