On Thu, Sep 08, 2016 at 09:58:13AM -0600, Stephen Warren wrote: > On 09/07/2016 07:29 PM, Masahiro Yamada wrote: > >Hi Stephen > > > > > >2016-09-08 1:15 GMT+09:00 Stephen Warren <swar...@wwwdotorg.org>: > >>Masahiro, > >> > >>In patch 6e7e9294d321 "usb: add basic USB configs in Kconfig", you added > >>"config USB_STORAGE" to drivers/usb/Kconfig. However, it's still just > >>#defined by many include/configs/*.h rather than being defined in > >>configs/*_defconfig. Is that a problem? It seems to work in practice, but > >>leads people adding new boards to put the definition in configs/*_defconfig > >>which then may be inconsistent with similar existing boards which have it > >>defined in include/configs/*.h. > > > >Once we create an entry in Kconfig, > >all the defines in include/configs/*.h should be moved. > > That's what I imagined. The commit above didn't do that though; are > you planning on sending a fix?
Since those are often conflict-happy I'll take care of it. I probably intended to, even. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
