>>>>> "Stephen" == Stephen Warren <swar...@wwwdotorg.org> writes:
Stephen> On 08/29/2016 06:51 PM, peter.ch...@data61.csiro.au wrote: >> The Colorado TK1 SOM is a small form factor board similar to the >> Jetson TK1. The main differences lie in the pinmux, and in that >> the PCIe controller is set to use in 4lanes+1lane, rather than 2+2. >> >> The pinmux header here was generated from a spreadsheet provided by >> Colorado Engineering using the tegra-pinmux scripts. The >> spreadsheet was converted from v09 to v11 by me. >> diff --git a/arch/arm/mach-tegra/tegra124/Kconfig >> b/arch/arm/mach-tegra/tegra124/Kconfig >> +config TARGET_CEI_TK1_SOM + bool "Colorado/NVIDIA Tegra124 TK1-som >> board" Stephen> I think that should say: Stephen> bool "Colorado Engineering Inc TK1-som board" Stephen> I assume that NVIDIA had no part in creating this derivative; Stephen> they simply created the board it was based on. As far a I know that's the case. It's an NVIDIA SoC though. >> diff --git a/include/configs/cei-tk1-som.h >> b/include/configs/cei-tk1-som.h >> + * (C) Copyright 2016 Peter Chubb >> + * Based on the jetson-tk1.h which is Stephen> There's trailing whitespace on that line. Stephen> I might suggest adding a : to the end of the line, so it's Stephen> more obvious (when looking at just the added lines) that it's Stephen> referring to the next line rather than a statement that Stephen> wasn't finished. OK. I need to fix the copyright header too (my employer wants a mention, which is fair enough as they're paying for me to do this work)) Stephen> Is that true? I'd like to see a patch for Stephen> tegra-pinmux-scripts that adds the config file for this board Stephen> too. It's on its way. I'm currently trying to get the Linux DTS part working. Stephen> Aside from those minor issues, Acked-by: Stephen Warren Stephen> <swar...@nvidia.com> Thanks. -- Dr Peter Chubb Tel: +61 2 9490 5852 http://www.data61.csiro.au http://ts.data61.csiro.au Software Systems Research Group/NICTA/Data61 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
