Hi Liu,

I have posted the patch for the same.
Have a look at the attachment.

Thanks
Dipen


-----Original Message-----
From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de]
On Behalf Of Liu Dave-R63238
Sent: Saturday, September 19, 2009 5:31 AM
To: Kumar Gala; Hu Mingkai-B21284
Cc: Wood Scott-B07421; u-boot@lists.denx.de
Subject: Re: [U-Boot] [PATCH v3 1/3] NAND boot: MPC8536DS support

> > diff --git a/cpu/mpc85xx/cpu_init_nand.c

> > +void cpu_init_f(void)
> > +{
> > +   ccsr_lbc_t *lbc = (void *)(CONFIG_SYS_MPC85xx_LBC_ADDR);
> > +
> > +   /*
> > +    * LCRR - Clock Ratio Register - set up local bus timing
> > +    * when needed
> > +    */
> > +   out_be32(&lbc->lcrr, LCRR_DBYP | LCRR_CLKDIV_8);
> > +
> > +#if defined(CONFIG_NAND_BR_PRELIM)  \
> > +   && defined(CONFIG_NAND_OR_PRELIM)
> > +   out_be32(&lbc->br0, CONFIG_NAND_BR_PRELIM);
> > +   out_be32(&lbc->or0, CONFIG_NAND_OR_PRELIM);
> > +   /* for FPGA */
> > +   out_be32(&lbc->br3, CONFIG_SYS_BR3_PRELIM);
> > +   out_be32(&lbc->or3, CONFIG_SYS_OR3_PRELIM); #else #error  
> > +CONFIG_NAND_BR_PRELIM, CONFIG_NAND_OR_PRELIM must
> be defined
> > +#endif
> > +
> 
> Should we not have br/or1, br/or2, etc?
> 

And FPGA stuff put here cpu/mpc85xx.....
It is *not* good practice and should be move out from here.
I know the FPGA is for UART clock.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

--- Begin Message ---
Signed-off-by: Dipen Dudhat <dipen.dud...@freescale.com>
---
-Please ignore the last patch of the same.
 cpu/mpc85xx/cpu_init_nand.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/cpu/mpc85xx/cpu_init_nand.c b/cpu/mpc85xx/cpu_init_nand.c
index e62f8d3..ed0eb2d 100644
--- a/cpu/mpc85xx/cpu_init_nand.c
+++ b/cpu/mpc85xx/cpu_init_nand.c
@@ -37,9 +37,12 @@ void cpu_init_f(void)
        && defined(CONFIG_NAND_OR_PRELIM)
        out_be32(&lbc->br0, CONFIG_NAND_BR_PRELIM);
        out_be32(&lbc->or0, CONFIG_NAND_OR_PRELIM);
+#if defined(CONFIG_SYS_BR3_PRELIM) \
+       && defined(CONFIG_SYS_OR3_PRELIM)
        /* for FPGA */
        out_be32(&lbc->br3, CONFIG_SYS_BR3_PRELIM);
        out_be32(&lbc->or3, CONFIG_SYS_OR3_PRELIM);
+#endif
 #else
 #error  CONFIG_NAND_BR_PRELIM, CONFIG_NAND_OR_PRELIM must be defined
 #endif
-- 
1.5.6.3





--- End Message ---
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to