> -----Original Message----- > From: Wolfgang Denk [mailto:w...@denx.de] > Sent: Friday, September 11, 2009 4:08 PM > To: Hu Mingkai-B21284 > Cc: u-boot@lists.denx.de; ga...@kernel.crashing.org; Wood Scott-B07421 > Subject: Re: [PATCH v2 1/2] mkconfig: split the board make > target to multiple config targets > > Dear Mingkai Hu, > > In message > <1252466603-25103-1-git-send-email-mingkai...@freescale.com> > you wrote: > > To simplify the top level makefile it useful to be able to > parse the > > top level makefile target to multiple individual target, > then put them > > to the config.h, leave the board config file to handle the > different > > targets. > > > > Note that this method uses the '_'(underline) as the delimiter when > > splits the board make target. > > > > Signed-off-by: Mingkai Hu <mingkai...@freescale.com> > > --- > > > > According to the comments from Wolfgang and Scott, I modified the > > patch and made some modification over v1: > > > > - remove the sectence thats puts the splited variables to the > > config.mk, we can use the CONFIG_MK_* in the board config file > > to override the variable in the board config file. > > > > - change CONFIG_OPT_* to CONFIG_MK_* > > > > mkconfig | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > Arghhh... It seems this patch has not been well tested. > Obviously never ever ran a MAKEALL over all PPC boards. It > causes tons of messages like that: > > include/config.h:2:25: warning: missing whitespace after the > macro name > > This patch breaks building for a number of boards / configurations, > especially: > > xilinx-ppc405-generic_flash > xilinx-ppc405-generic > xilinx-ppc440-generic_flash > xilinx-ppc440-generic > VoVPN-GW_66MHz > VoVPN-GW_100MHz > EB+MCF-EV123 > EB+MCF-EV123_internal > microblaze-generic > favr-32-ezkit > > > Shall I revert that patch? >
Oh..., sorry, I don't run makeall to test and fell free to revert it, but not this patch, this patch doesn't be included on your git tree, I think you means the following patch: http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commit;h=511c02f611 cb5afa1b8ca5980caaaabaa0de377f Obviously, this patch also causes these issues, so can I parse the board config name in the top make file by using the "findstring" method which will make the top make file a little lengthy? If yes, I'll resend the patchset for boot from NAND/eSDHC/eSPI again. Thanks, Mingkai _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
